Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update MSRV to 1.72 #1194

Merged
merged 3 commits into from
Apr 24, 2024
Merged

chore(deps): update MSRV to 1.72 #1194

merged 3 commits into from
Apr 24, 2024

Conversation

rnbguy
Copy link
Collaborator

@rnbguy rnbguy commented Apr 24, 2024

Closes: #1193

Description

One of the sub-dependency, zeroize, requires the MSRV 1.72.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@rnbguy rnbguy marked this pull request as ready for review April 24, 2024 17:07
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@ee7f671). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1194   +/-   ##
=======================================
  Coverage        ?   64.33%           
=======================================
  Files           ?      229           
  Lines           ?    22083           
  Branches        ?        0           
=======================================
  Hits            ?    14208           
  Misses          ?     7875           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@seanchen1991 seanchen1991 added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit ddd3f48 Apr 24, 2024
20 checks passed
@seanchen1991 seanchen1991 deleted the rano/deps/msrv branch April 24, 2024 17:10
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* update msrv to 1.72

* changelog entry

* nit on older changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump minimum supported rust version to 1.72
2 participants