Make connection events compatible with ibc-go #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plafer
commented
Oct 26, 2022
Signed-off-by: Philippe Laferrière <plafer@protonmail.com>
romac
approved these changes
Oct 26, 2022
plafer
commented
Oct 26, 2022
| let counterparty_conn_id = Tag { | ||
| key: COUNTERPARTY_CONN_ID_ATTRIBUTE_KEY.parse().unwrap(), | ||
| value: match a.counterparty_connection_id { | ||
| Some(counterparty_conn_id) => counterparty_conn_id.to_string().parse().unwrap(), |
There was a problem hiding this comment.
Note: opened this issue in tendermint-rs to eventually clean up the .parse().unwrap().
shuoer86
pushed a commit
to shuoer86/ibc-rs
that referenced
this pull request
Nov 4, 2023
…/js (cosmos#191) Bumps [eslint-plugin-simple-import-sort](https://github.com/lydell/eslint-plugin-simple-import-sort) from 7.0.0 to 10.0.0. - [Changelog](https://github.com/lydell/eslint-plugin-simple-import-sort/blob/main/CHANGELOG.md) - [Commits](lydell/eslint-plugin-simple-import-sort@v7.0.0...v10.0.0) --- updated-dependencies: - dependency-name: eslint-plugin-simple-import-sort dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* OpenInit event refactored * conn_open_init emits proper event * fix all other connection events * conn_open_try now outputs proper event * adopt naming convention in event ctor * conn_open_ack emits proper event * conn_open_confirm now emits proper event * remove unneeded function * clippy fixes * changelog * nit improvement * Update crates/ibc/src/core/ics03_connection/events.rs Signed-off-by: Philippe Laferrière <plafer@protonmail.com> Signed-off-by: Philippe Laferrière <plafer@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #145
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.