Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Serde feature #301

Closed
wants to merge 1 commit into from

Conversation

DaviRain-Su
Copy link
Contributor

Closes: #293

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@DaviRain-Su
Copy link
Contributor Author

Now this PR is draw, when 259 merge into master this will rebase this branch

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 66.14% // Head: 65.86% // Decreases project coverage by -0.27% ⚠️

Coverage data is based on head (c093829) compared to base (4c16095).
Patch coverage: 38.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
- Coverage   66.14%   65.86%   -0.28%     
==========================================
  Files         125      125              
  Lines       13045    13105      +60     
==========================================
+ Hits         8628     8631       +3     
- Misses       4417     4474      +57     
Impacted Files Coverage Δ
crates/ibc/src/core/ics03_connection/events.rs 32.07% <0.00%> (-1.05%) ⬇️
crates/ibc/src/core/ics04_channel/timeout.rs 39.04% <ø> (ø)
crates/ibc/src/events.rs 15.62% <0.00%> (-0.41%) ⬇️
crates/ibc/src/core/ics04_channel/commitment.rs 20.58% <25.00%> (-1.29%) ⬇️
crates/ibc/src/core/ics23_commitment/specs.rs 58.94% <25.00%> (-2.60%) ⬇️
crates/ibc/src/proofs.rs 50.00% <25.00%> (-2.09%) ⬇️
...s/ibc/src/clients/ics07_tendermint/client_state.rs 55.83% <33.33%> (-0.20%) ⬇️
crates/ibc/src/core/ics03_connection/connection.rs 29.24% <37.50%> (-0.38%) ⬇️
crates/ibc/src/core/ics04_channel/channel.rs 53.16% <40.00%> (-0.86%) ⬇️
crates/ibc/src/core/ics24_host/identifier.rs 61.00% <41.66%> (-1.73%) ⬇️
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DaviRain-Su DaviRain-Su reopened this Dec 28, 2022
@hu55a1n1 hu55a1n1 mentioned this pull request Jan 6, 2023
7 tasks
@plafer
Copy link
Contributor

plafer commented Jan 9, 2023

Closing in favor of #331.

@plafer plafer closed this Jan 9, 2023
@DaviRain-Su DaviRain-Su deleted the 293-serde-feature branch January 11, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider putting serde behind a feature flag
2 participants