-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADR 006: Upgrade client implementation proposal #383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🎉👌! I'm now convinced that we can have an upgrade handler that's compatible with ibc-go (modulo a few questions I left in this review).
Thank you for the comments 🙏 |
* Remove trusting period bound for general MUSTs * Revise clause related to proof verification * Add a NOTE for chain-level upgrade steps * Reword height check clause
7dcbdb4
to
ec94b51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
* Initial ADR-006 draft * Apply some revisions * Add a description for zero_custom_fields * Apply some revisions * Apply review comments * Remove trusting period bound for general MUSTs * Revise clause related to proof verification * Add a NOTE for chain-level upgrade steps * Reword height check clause * Add description for sentinel value * Clarify basic vs upgrade-specific validations + notice for upgradedConsState
Closes: #362
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.