Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 006: Upgrade client implementation proposal #383

Merged
merged 7 commits into from
Jan 31, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Jan 27, 2023

Closes: #362


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🎉👌! I'm now convinced that we can have an upgrade handler that's compatible with ibc-go (modulo a few questions I left in this review).

@Farhad-Shabani
Copy link
Member Author

Thank you for the comments 🙏
I'll retouch this proposal after investigating some more corners plus the points you mentioned.

* Remove trusting period bound for general MUSTs

* Revise clause related to proof verification

* Add a NOTE for chain-level upgrade steps

* Reword height check clause
@Farhad-Shabani Farhad-Shabani force-pushed the farhad/adr06-upgrade-client branch from 7dcbdb4 to ec94b51 Compare January 31, 2023 05:01
@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review January 31, 2023 15:24
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@Farhad-Shabani Farhad-Shabani merged commit 0605dd3 into main Jan 31, 2023
@Farhad-Shabani Farhad-Shabani deleted the farhad/adr06-upgrade-client branch January 31, 2023 19:30
@Farhad-Shabani Farhad-Shabani added this to the ADR06 milestone Feb 2, 2023
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* Initial ADR-006 draft

* Apply some revisions

* Add a description for zero_custom_fields

* Apply some revisions

* Apply review comments

* Remove trusting period bound for general MUSTs

* Revise clause related to proof verification

* Add a NOTE for chain-level upgrade steps

* Reword height check clause

* Add description for sentinel value

* Clarify basic vs upgrade-specific validations + notice for upgradedConsState
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

ADR 006: Implement upgrade client functionality
2 participants