Update send packet/transfer #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 69.54% // Head: 71.30% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
==========================================
+ Coverage 69.54% 71.30% +1.76%
==========================================
Files 126 126
Lines 16228 15935 -293
==========================================
+ Hits 11285 11363 +78
+ Misses 4943 4572 -371
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Farhad-Shabani
added
the
A: breaking
| } | ||
|
|
||
| pub fn process_recv_packet_execute<Ctx: TokenTransferContext>( | ||
| pub fn process_recv_packet_execute<Ctx: TokenTransferExecutionContext>( | ||
| ctx: &mut Ctx, |
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* send_packet_validate() * send_packet_execute * send_transfer_validate * fmt * send_transfer_validate: call send_packet_validate * send_transfer_execute * SendPacketValidationContext * send_packet_validate uses SendPacketValidationContext * SendPacketExecutionContext * TokenTransferExecutionContext * cleanup * remove unused recv_packet * Remove `ModuleOutput` * Remove unused `Module` callbacks * changelog * use CommitmentPath ctor * add back send_transfer comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #442
send_{packet,transfer}()into*_validation()and*_execution()ModuleOutput/ModuleOutputBuilderstructsModulePR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.