Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve is_send/recieve_enabled interfaces in transfer app #516

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Mar 9, 2023

Closes: #508


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review March 9, 2023 18:15
@Farhad-Shabani Farhad-Shabani requested a review from plafer March 9, 2023 18:15
@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Patch coverage: 37.50% and no project coverage change.

Comparison is base (7311bbd) 71.83% compared to head (cf78644) 71.84%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #516   +/-   ##
=======================================
  Coverage   71.83%   71.84%           
=======================================
  Files         126      126           
  Lines       15852    15836   -16     
=======================================
- Hits        11387    11377   -10     
+ Misses       4465     4459    -6     
Impacted Files Coverage Δ
crates/ibc/src/applications/transfer/context.rs 51.06% <ø> (ø)
crates/ibc/src/applications/transfer/error.rs 0.00% <ø> (ø)
.../src/applications/transfer/relay/on_recv_packet.rs 0.00% <0.00%> (ø)
crates/ibc/src/mock/context.rs 75.11% <50.00%> (ø)
...c/src/applications/transfer/relay/send_transfer.rs 95.83% <100.00%> (+0.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@plafer plafer merged commit 1059519 into main Mar 9, 2023
@plafer plafer deleted the farhad/improve-is-send-receive-interface branch March 9, 2023 18:31
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* Improve  interfaces in transfer app

* Revise changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Transfer App] Return Result instead of boolean for is_send_enabled and is_receive_enabled‍‍ methods
2 participants