Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

emit a message event for send_packet #575

Merged
merged 3 commits into from
Mar 28, 2023
Merged

emit a message event for send_packet #575

merged 3 commits into from
Mar 28, 2023

Conversation

yito88
Copy link
Contributor

@yito88 yito88 commented Mar 27, 2023

Closes: #574

Description

Emit a message event for SendPacket.
Sorry, I forgot to do in #564.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Mar 27, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (00f9c8e) 73.02% compared to head (045c865) 73.03%.

❗ Current head 045c865 differs from pull request most recent head f48c6d1. Consider uploading reports for the commit f48c6d1 to get more accurate results

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #575   +/-   ##
=======================================
  Coverage   73.02%   73.03%           
=======================================
  Files         126      126           
  Lines       15679    15681    +2     
=======================================
+ Hits        11450    11453    +3     
+ Misses       4229     4228    -1
Impacted Files Coverage Δ
.../ibc/src/core/ics04_channel/handler/send_packet.rs 85.56% <100.00%> (+0.30%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

plafer
plafer approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@plafer plafer merged commit ffae7ea into cosmos:main Mar 28, 2023
@yito88 yito88 deleted the yuji/send-packet-message-event branch March 28, 2023 13:33
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
@yito88
emit a message event for send_packet (#575)
fb5306f 
* emit a message event for send_packet

* add changelog

* fix for changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plafer plafer plafer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Message event for SendPacket
2 participants
@yito88 @plafer