Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ics04_channel: Add (de)serialization for ModuleExtras #581

Merged
merged 1 commit into from
Mar 29, 2023
Merged

ics04_channel: Add (de)serialization for ModuleExtras #581

merged 1 commit into from
Mar 29, 2023

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Mar 29, 2023

Closes: #XXX

Description

This makes it easier to pass ModuleExtras across serialization boundaries.


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

Copy link
Contributor

@plafer plafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@plafer plafer merged commit 585d2ab into cosmos:main Mar 29, 2023
@kevinji kevinji deleted the moduleextras-serialization branch March 29, 2023 21:13
@kevinji kevinji mentioned this pull request Mar 31, 2023
7 tasks
Farhad-Shabani pushed a commit that referenced this pull request Mar 31, 2023
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants