Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant #[allow(clippy::too_many_arguments)] #675

Merged
merged 1 commit into from
May 11, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented May 11, 2023

Closes: #674


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (07ddc96) 72.86% compared to head (bc69962) 72.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #675   +/-   ##
=======================================
  Coverage   72.86%   72.86%           
=======================================
  Files         113      113           
  Lines       15258    15258           
=======================================
  Hits        11118    11118           
  Misses       4140     4140           
Impacted Files Coverage Δ
crates/ibc/src/applications/transfer/context.rs 51.81% <ø> (ø)
crates/ibc/src/core/router.rs 81.19% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@plafer plafer merged commit 455029d into main May 11, 2023
@plafer plafer deleted the farhad/remove-too-many-args branch May 11, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove redundant #[allow(clippy::too_many_arguments)]
2 participants