-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp(ics24)!: enhancements and fixes to ChainId
impl and validation
#762
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
==========================================
- Coverage 73.41% 71.32% -2.09%
==========================================
Files 125 124 -1
Lines 16127 14796 -1331
==========================================
- Hits 11839 10553 -1286
+ Misses 4288 4243 -45
☔ View full report in Codecov by Sentry. |
ChainId
to create and validate them more precisely and efficientlyChainId
to construct and validate more precisely and efficiently
ChainId
to construct and validate more precisely and efficientlyChainId
impl and validation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's run the integration tests before we merge though
…osmos#762) * imp(ChainId): refactor abstraction and validations * misc: add unclog * fix: clippy catches * fix: revert ChainId definition + improve checks * fix: set_revision_number
…762) * imp(ChainId): refactor abstraction and validations * misc: add unclog * fix: clippy catches * fix: revert ChainId definition + improve checks * fix: set_revision_number
Closes: #761
PR author checklist:
unclog
.docs/
).Reviewer checklist:
Files changed
in the GitHub PR explorer.