f32/f64/usize in cosmwasm(and other no f32/f64 envs) reproduction and fixes #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #894 +/- ##
==========================================
- Coverage 67.67% 67.51% -0.16%
==========================================
Files 131 131
Lines 16079 16091 +12
==========================================
- Hits 10881 10864 -17
- Misses 5198 5227 +29
☔ View full report in Codecov by Sentry. |
|
Hey @tzemanovic, Could you please take a look at this branch and let me know if it fits your needs? Thanks! |
It does, thank you! |
romac
approved these changes
Oct 13, 2023
romac
reviewed
Oct 13, 2023
Co-authored-by: Romain Ruetschi <romain@informal.systems> Signed-off-by: Farhad Shabani <Farhad.Shabani@gmail.com>
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
… fixes (#894) * fixed f64/f32 validation in wasm * what to do with serde json? main one is float, fork from cw is std, my fork pr not merged for no std * apply some adjustments + update cargo.lock for cw-check * deps: bump serde-json-wasm to v1.0.0 * chore: add unclog * ci: add cw-check * fix: remove cachix * fix: not needed to install/cache Rust in CI * imp: run CI only on releases and main branch * nit: on pull_request * nit: max_history_size as u64 * test: calculate_block_delay * nit: remove u64::max * Apply suggestions from code review Co-authored-by: Romain Ruetschi <romain@informal.systems> Signed-off-by: Farhad Shabani <Farhad.Shabani@gmail.com> --------- Signed-off-by: Farhad Shabani <Farhad.Shabani@gmail.com> Co-authored-by: dzmitry-lahoda <dzmitry@lahoda.pro> Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #850
Supersedes: #803
Remark
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.