optimization: reduce heap allocation #970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer str::from_utf8 over String::from_utf8 to avoid unnecesary heap allocation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #970 +/- ##
=======================================
Coverage 70.24% 70.24%
=======================================
Files 177 177
Lines 17730 17730
=======================================
Hits 12455 12455
Misses 5275 5275 ☔ View full report in Codecov by Sentry. |
|
Thanks a bunch for this PR @blasrodri. Just needs a unclog + |
Farhad-Shabani
added
the
O: optimization
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
* optimization: reduce heap allocation Prefer str::from_utf8 over String::from_utf8 to avoid unnecesary heap allocation * fmt * chore: add unclog --------- Co-authored-by: Farhad Shabani <farhad.shabani@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer str::from_utf8 over String::from_utf8 to avoid
unnecesary heap allocation
Closes: #XXX
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.