Skip to content

Commit

Permalink
ICS2: 02 client refactor (#813)
Browse files Browse the repository at this point in the history
* split verify and update functions into 4 functions defined in ADR

* verify functions and example changes

* add getTimestampAtHeight to ClientState interface

* changelog

* Apply suggestions from code review

Co-authored-by: Marius Poke <marius.poke@posteo.de>

* remove non-example instances of Header

* clientmsg definition

* fix updateClient pseudocode

* address marius reviews

* fix headings

Co-authored-by: Marius Poke <marius.poke@posteo.de>
  • Loading branch information
AdityaSripal and mpoke authored Aug 31, 2022
1 parent 0a43605 commit f9ac787
Show file tree
Hide file tree
Showing 2 changed files with 138 additions and 401 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ Ref: https://keepachangelog.com/en/1.0.0/

## [Unreleased]

### API-Breaking

- [\#813](https://github.com/cosmos/ibc/pull/813) Breaks up `checkValidityAndUpdateState` into `verifyClientMessage` and `UpdateState`
- [\#813](https://github.com/cosmos/ibc/pull/813) Breaks up `checkMisbehaviourAndUpdateState` into `checkForMisbehaviour` and `UpdateStateOnMisbehaviour`
- [\#813](https://github.com/cosmos/ibc/pull/813) Removes `Header` and `Misbehaviour` interfaces for generic `ClientMessage` interface
- [\#813](https://github.com/cosmos/ibc/pull/813) Removes specific verify functions from ClientState interface in exchange for generic `verifyMembership` and `verifyNonMembership` methods
- [\#813](https://github.com/cosmos/ibc/pull/813) Adds `getTimeoutAtHeight` method to ClientState interface.

### Bug Fixes

- [\#808](https://github.com/cosmos/ibc/pull/808) Fix channel sequence paths in ICS4
Expand Down
Loading

0 comments on commit f9ac787

Please sign in to comment.