Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS3: Add Connection Upgrade Spec #621

Merged
merged 29 commits into from
Mar 22, 2022
Merged
Changes from 1 commit
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
e0fa2e1
connection upgrade progress
AdityaSripal Nov 30, 2021
cb0b5c5
initial writeup
AdityaSripal Dec 1, 2021
067956e
add notes on init and try access control
AdityaSripal Dec 1, 2021
dc00b01
address colin suggestions
AdityaSripal Dec 3, 2021
82f7286
Apply suggestions from code review
AdityaSripal Dec 6, 2021
26169bd
address chris initial review
AdityaSripal Dec 6, 2021
b7ab84d
Merge branch 'aditya/path-upgrade' of github.com:cosmos/ibc into adit…
AdityaSripal Dec 6, 2021
d71f150
add timeout logic
AdityaSripal Feb 10, 2022
e398dbb
crossing hellos logic
AdityaSripal Feb 11, 2022
b92cced
migrations and crossing hello cleanup
AdityaSripal Feb 11, 2022
e7ff7bf
Apply suggestions from code review
AdityaSripal Feb 22, 2022
bd795ae
continue addressing @mpoke suggestions
AdityaSripal Feb 28, 2022
da255ad
clarify handshake pseudocode
AdityaSripal Mar 1, 2022
d5588c8
remove unnecessary structs and simplify protocol
AdityaSripal Mar 2, 2022
3d30b28
clarify TRY actor reasoning
AdityaSripal Mar 2, 2022
37916cd
TRY timeout clarification
AdityaSripal Mar 2, 2022
f483d1f
cleanup pseudocode
AdityaSripal Mar 2, 2022
7239327
fix mistakes after readthrough
AdityaSripal Mar 7, 2022
6f7f572
chan->conn
AdityaSripal Mar 7, 2022
758e5ab
Apply suggestions from code review
AdityaSripal Mar 9, 2022
67f2a03
complete fixing minor issues
AdityaSripal Mar 9, 2022
c40ab29
Merge branch 'aditya/path-upgrade' of github.com:cosmos/ibc into adit…
AdityaSripal Mar 9, 2022
a152627
reorder utility function and fix timeout conditional bug
AdityaSripal Mar 9, 2022
6a59321
fix restore connection logic
AdityaSripal Mar 14, 2022
a4c9fdc
use 02-client generic verify methods
AdityaSripal Mar 15, 2022
7359894
address colin comments
AdityaSripal Mar 15, 2022
849059a
Apply suggestions from code review
AdityaSripal Mar 22, 2022
c261dd3
address rest of reviews
AdityaSripal Mar 22, 2022
1948a82
use connection method
AdityaSripal Mar 22, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clarify TRY actor reasoning
  • Loading branch information
AdityaSripal committed Mar 2, 2022
commit 3d30b283f7e2955f6defe136d85d32f3cfd478df
2 changes: 1 addition & 1 deletion spec/core/ics-003-connection-semantics/UPGRADES.md
Original file line number Diff line number Diff line change
@@ -326,7 +326,7 @@ function connUpgradeTry(
}
```

NOTE: It is up to individual implementations how they will provide access-control to the `ConnUpgradeTry` function. E.g. chain governance, permissioned actor, DAO, etc.
NOTE: It is up to individual implementations how they will provide access-control to the `ConnUpgradeTry` function. E.g. chain governance, permissioned actor, DAO, etc. A chain may decide to have permissioned **or** permissionless `UpgradeTry`. In the permissioned case, both chains must explicitly consent to the upgrade, in the permissionless case; one chain initiates the upgrade and the other chain agrees to the upgrade by default. In the permissionless case, a relayer may submit the `ConnUpgradeTry` datagram.


```typescript