ICS4: Channel Upgradability Spec #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raulnori77
approved these changes
Mar 15, 2022
colin-axner
reviewed
Mar 21, 2022
Comment on lines
+379
to
+383
| if !IsCompatible(counterpartyChannel, proposedUpgradeChannel) { | ||
| restoreChannel() | ||
| return | ||
| } | ||
|
|
There was a problem hiding this comment.
this seems like leftover code from crossing hellos case handled above?
There was a problem hiding this comment.
Indeed. counterpartyChannel is not defined.
There was a problem hiding this comment.
Sorry my mistake. Needed to define and prove counterpartyChannel earlier. counterpartyChannel is the channel that initiator upgraded to.
proposedUpgradeChannel is the channel that TRY is going to upgrade to.
Similar to the connection upgrade channel there needs to be some check on compatibility that will not be specified here since it is upgrade-specific.
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
mpoke
requested changes
Mar 22, 2022
|
|
||
| // call modules onChanUpgradeAck callback | ||
| module = lookupModule(portIdentifier) | ||
| err = module.onChanUpgradeAck( |
There was a problem hiding this comment.
In #686, onChanUpgradeAck returns no error.
Co-authored-by: Marius Poke <marius.poke@posteo.de>
mpoke
approved these changes
Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.