Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICS2: 02 client refactor #813

Merged
merged 10 commits into from
Aug 31, 2022
Merged

ICS2: 02 client refactor #813

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
517963d
split verify and update functions into 4 functions defined in ADR
AdityaSripal Aug 4, 2022
2d5427c
verify functions and example changes
AdityaSripal Aug 4, 2022
5a33977
add getTimestampAtHeight to ClientState interface
AdityaSripal Aug 4, 2022
82129c7
changelog
AdityaSripal Aug 4, 2022
da71ea8
Apply suggestions from code review
AdityaSripal Aug 17, 2022
99554dc
remove non-example instances of Header
AdityaSripal Aug 17, 2022
61a1a9c
clientmsg definition
AdityaSripal Aug 17, 2022
360a26d
fix updateClient pseudocode
AdityaSripal Aug 17, 2022
c70ae5b
address marius reviews
AdityaSripal Aug 24, 2022
b6f4048
fix headings
AdityaSripal Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,14 @@ Ref: https://keepachangelog.com/en/1.0.0/

## [Unreleased]

### API-Breaking

- [\#813](https://github.com/cosmos/ibc/pull/813) Breaks up `checkValidityAndUpdateState` into `verifyClientMessage` and `UpdateState`
- [\#813](https://github.com/cosmos/ibc/pull/813) Breaks up `checkMisbehaviourAndUpdateState` into `checkForMisbehaviour` and `UpdateStateOnMisbehaviour`
- [\#813](https://github.com/cosmos/ibc/pull/813) Removes `Header` and `Misbehaviour` interfaces for generic `ClientMessage` interface
mpoke marked this conversation as resolved.
Show resolved Hide resolved
- [\#813](https://github.com/cosmos/ibc/pull/813) Removes specific verify functions from ClientState interface in exchange for generic `verifyMembership` and `verifyNonMembership` methods
- [\#813](https://github.com/cosmos/ibc/pull/813) Adds `getTimeoutAtHeight` method to ClientState interface.

### Bug Fixes

- [\#808](https://github.com/cosmos/ibc/pull/808) Fix channel sequence paths in ICS4
Expand Down
Loading