Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change cosmos.ics23.v1.serde mod to no-std. #154

Closed
wants to merge 1 commit into from

Conversation

riversyang
Copy link

Motivation

During the integration of ibc-rs v0.41.0 (which uses ics23 v0.10.1) into near-ibc, I encountered compile errors in the cosmos.ics23.v1.serde module of ics23. The module was using several std types that are not allowed in NEAR smart contracts.

To resolve this, I made the necessary changes to allow compilation. I believe it would be beneficial to also commit these changes to the original repository.

All Changes

  • Replace std in cosmos.ics23.v1.serde to core.
  • Add use for format macro and Vec of alloc in cosmos.ics23.v1.serde.

* Replace `std` in `cosmos.ics23.v1.serde` to `core`.
* Add use for `format` macro and `Vec` of `alloc` in `cosmos.ics23.v1.serde`.
@riversyang riversyang changed the title Change cosmos.ics23.v1.serde mod to no-std. fix: Change cosmos.ics23.v1.serde mod to no-std. Jul 1, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Patch coverage: 44.34% and project coverage change: +16.57 🎉

Comparison is base (d0edf8e) 48.76% compared to head (c2b34d2) 65.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #154       +/-   ##
===========================================
+ Coverage   48.76%   65.33%   +16.57%     
===========================================
  Files          24        8       -16     
  Lines        9903     3551     -6352     
  Branches       86        0       -86     
===========================================
- Hits         4829     2320     -2509     
+ Misses       4717     1231     -3486     
+ Partials      357        0      -357     
Flag Coverage Δ
go ?
rust 65.33% <44.34%> (+0.05%) ⬆️
typescript ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/src/cosmos.ics23.v1.serde.rs 40.43% <44.34%> (+0.10%) ⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romac
Copy link
Member

romac commented Aug 16, 2023

Superseded by #158

@romac romac closed this Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants