Add buf.build #59
Add buf.build #59
Conversation
proto/confio/v1/proofs.proto
Outdated
| @@ -1,16 +1,18 @@ | |||
| syntax = "proto3"; | |||
|
|
|||
| package ics23; | |||
| package confio.v1.ics23; | |||
There was a problem hiding this comment.
this will need to be regenerated, want to double check if its okay before doing so.
DO NOT MERGE
There was a problem hiding this comment.
Sure, we can rename this.
Let's make sure this gets into a 0.7.0 release as it is breaking for the client.
I assume the wire format doesn't change, which we do try to avoid.
There was a problem hiding this comment.
correct wire format does not change. Would you be up for cutting 1.0?
proto/confio/v1/proofs.proto
Outdated
| @@ -1,16 +1,18 @@ | |||
| syntax = "proto3"; | |||
|
|
|||
| package ics23; | |||
| package confio.v1.ics23; | |||
There was a problem hiding this comment.
Sure, we can rename this.
Let's make sure this gets into a 0.7.0 release as it is breaking for the client.
I assume the wire format doesn't change, which we do try to avoid.
|
this is ready for go. For js, its unclear to me what I need to run? Rust, is panicking |
Ooh, sounds like fun. I will come back to this when I have a bit of time. |
But provides a layout to the repo that is common amongst Protobuf repos. This helps with registering proto types in the proto registry.
In ibc, proofs.proto is imported via confio/proofs.proto, which fails in grace reflection as its not correct in the proto registry
closes #32