test: Ports key assignment to the driver on the PSS feature branch (#…

…1628)

* Port key assignment to MBT driver

* Add comment and make var names clearer

tests/mbt/driver/core.go

@@ -375,12 +375,12 @@ func (s *Driver) setTime(chain ChainId, newTime time.Time) {
 	testChain.App.BeginBlock(abcitypes.RequestBeginBlock{Header: testChain.CurrentHeader})
 }
 
-func (s *Driver) AssignKey(chain ChainId, valIndex int64, value crypto.PublicKey) error {
+func (s *Driver) AssignKey(chain ChainId, valIndex int64, key crypto.PublicKey) error {
 	stakingVal, found := s.stakingValidator(valIndex)
 	if !found {
 		return fmt.Errorf("validator with id %v not found on provider", valIndex)
 	}
-	return s.providerKeeper().AssignConsumerKey(s.providerCtx(), string(chain), stakingVal, value)
+	return s.providerKeeper().AssignConsumerKey(s.providerCtx(), string(chain), stakingVal, key)
 }
 
 // DeliverPacketToConsumer delivers a packet from the provider to the given consumer recipient.

tests/mbt/driver/mbt_test.go

@@ -127,6 +127,10 @@ func RunItfTrace(t *testing.T, path string) {
 	_, _, consumerPrivVals, err := integration.CreateValidators(len(consumerAddressesExpr))
 	require.NoError(t, err, "Error creating consumer signers")
 
+	// consumerAddrNames are the human readable names of consumer addresses in the model
+	// "realAddrs" are the addresses of the consumer keys on chain
+	// these maps relate the consumerAddrNames to the priv validators (from which one can get the real address)
+	// and from the real ddresses to the consumerAddrNames to allow converting between the two easily
 	consumerAddrNamesToPrivVals := make(map[string]cmttypes.PrivValidator, len(consumerAddressesExpr))
 	realAddrsToModelConsAddrs := make(map[string]string, len(consumerAddressesExpr))
 	i := 0