Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sovereign -> consumer changeover is validated with e2e testing from the ICS repo #780

Closed
3 tasks
Tracked by #756
shaspitz opened this issue Mar 15, 2023 · 0 comments · Fixed by #1025 or #965
Closed
3 tasks
Tracked by #756

Sovereign -> consumer changeover is validated with e2e testing from the ICS repo #780

shaspitz opened this issue Mar 15, 2023 · 0 comments · Fixed by #1025 or #965
Assignees
@MSalopek
Labels
scope: docs Improvements or additions to documentation scope: testing Code review, testing, making sure the code is following the specification.

Comments

@shaspitz
Copy link
Contributor

shaspitz commented Mar 15, 2023 •
edited by MSalopek
Loading

Acceptance criteria:

  • add option to start soverign chain in e2e
  • add option to changeover sovereign chain to consumer
  • add tests to validate changeover success
@shaspitz shaspitz mentioned this issue Mar 15, 2023
Closed
@shaspitz shaspitz changed the title Feature is validated with integration testing from the ICS repo Sovereign -> consumer migration is validated with integration testing from the ICS repo Mar 15, 2023
@shaspitz shaspitz changed the title Sovereign -> consumer migration is validated with integration testing from the ICS repo Sovereign -> consumer changeover is validated with integration testing from the ICS repo Mar 15, 2023
@mpoke mpoke added this to Cosmos Hub Apr 14, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Apr 14, 2023
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Apr 14, 2023
@p-offtermatt p-offtermatt changed the title Sovereign -> consumer changeover is validated with integration testing from the ICS repo Sovereign -> consumer changeover is validated with e2e testing from the ICS repo May 22, 2023
@MSalopek MSalopek moved this from 📥 Todo to 🏗 In progress in Cosmos Hub May 25, 2023
@MSalopek MSalopek added scope: docs Improvements or additions to documentation scope: testing Code review, testing, making sure the code is following the specification. labels May 25, 2023
@MSalopek MSalopek mentioned this issue Jun 14, 2023
Closed
8 tasks
@MSalopek MSalopek moved this from 🏗 In progress to 🛑 Blocked in Cosmos Hub Jun 14, 2023
@mpoke mpoke moved this from 🛑 Blocked to 🏗 In progress in Cosmos Hub Jun 15, 2023
@MSalopek MSalopek mentioned this issue Jun 16, 2023
Merged
8 tasks
@MSalopek MSalopek linked a pull request Jun 16, 2023 that will close this issue
test: add sovereign to consumer changeover e2e #1025
Merged
8 tasks
@mpoke mpoke moved this from 🏗 In progress to 👀 In review in Cosmos Hub Jun 16, 2023
@MSalopek MSalopek linked a pull request Jun 16, 2023 that will close this issue
feat!: Add DistributionTransmissionChannel to ConsumerAdditionProposal #965
Merged
18 tasks
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cosmos Hub Jun 16, 2023
ThanhNhann pushed a commit to decentrio/interchain-security that referenced this issue Jan 3, 2024
@colin-axner
refactor: Fix RefundFeesOnChannel (cosmos#1244)
e59a6d2 
## Description

read cosmos#1060 

closes: cosmos#860
closes: cosmos#780 

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

- [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#pr-targeting))
- [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
- [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules/structure.md).
- [x] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/master/CONTRIBUTING.md#testing)
- [x] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`)
- [x] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
- [x] Added a relevant changelog entry to the `Unreleased` section in `CHANGELOG.md`
- [x] Re-reviewed `Files changed` in the Github PR explorer
- [x] Review `Codecov Report` in the comment section below once CI passes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MSalopek MSalopek

Labels
scope: docs Improvements or additions to documentation scope: testing Code review, testing, making sure the code is following the specification.
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
3 participants
@MSalopek @shaspitz @p-offtermatt