-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: GH workflow for publishing docker images #1593
Conversation
6f1ce74
to
0e1e72b
Compare
377a00f
to
eb82497
Compare
eb82497
to
fd749f4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me.
Unfortunately, iirc the only realistic way to test this is to merge and
check what it publishes. An alternative might be forking the repo to informalsystems and playing with it there (at least we don't mess with the real repo)
wdyt?
77f9675
to
fd749f4
Compare
yes you're right. did not find a way to test this outside the PR. will observe what is published and adapt if needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Workflow looks good as far as I can tell, so approval and let's see whether it works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments.
Let's reduce the amount of images being pushed. The most important events happen on push to main and when a tag/release is created.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
LGTM.
* Added GH workflow for publishing docker images * added pull request trigger * update actions * added match pattern for '-lsm' tags * addressed review comments (cherry picked from commit 9f375b4)
* Added GH workflow for publishing docker images * added pull request trigger * update actions * added match pattern for '-lsm' tags * addressed review comments (cherry picked from commit 9f375b4)
* Added GH workflow for publishing docker images * added pull request trigger * update actions * added match pattern for '-lsm' tags * addressed review comments (cherry picked from commit 9f375b4)
ci: GH workflow for publishing docker images (#1593) * Added GH workflow for publishing docker images * added pull request trigger * update actions * added match pattern for '-lsm' tags * addressed review comments (cherry picked from commit 9f375b4) Co-authored-by: bernd-m <43466467+bermuell@users.noreply.github.com>
ci: GH workflow for publishing docker images (#1593) * Added GH workflow for publishing docker images * added pull request trigger * update actions * added match pattern for '-lsm' tags * addressed review comments (cherry picked from commit 9f375b4) Co-authored-by: bernd-m <43466467+bermuell@users.noreply.github.com>
ci: GH workflow for publishing docker images (#1593) * Added GH workflow for publishing docker images * added pull request trigger * update actions * added match pattern for '-lsm' tags * addressed review comments (cherry picked from commit 9f375b4) Co-authored-by: bernd-m <43466467+bermuell@users.noreply.github.com>
Description
Closes: #1592
GH workflow to publish ICS docker images
Workflow is triggerd to build
interchain-security:latest
image when a commit is pushed to 'main' branchinterchain-security:vX.Y.Z
when a tag with pattern vX.Y.Z is pushedinterchain-security:vX.Y.Z-lsm
when a tag with pattern vX.Y.Z-lsm is pushedfor all other commits/tags no docker image workflow will be triggered
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...