-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add coderabbit configuration file #1852
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| language: "en" | ||
| early_access: false | ||
| reviews: | ||
| request_changes_workflow: false | ||
| high_level_summary: true | ||
| poem: false | ||
| review_status: false | ||
| collapse_walkthrough: true | ||
| path_filters: | ||
| - "!api/" | ||
| path_instructions: | ||
| - path: "**/*.go" | ||
| instructions: "Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations." | ||
| - path: "tests/e2e/*" | ||
| instructions: | | ||
| "Assess the e2e test code assessing sufficient code coverage for the changes associated in the pull request" | ||
| - path: "tests/integration/*" | ||
| instructions: | | ||
| "Assess the e2e test code assessing sufficient code coverage for the changes associated in the pull request" | ||
| - path: "**/*_test.go" | ||
| instructions: | | ||
| "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request" | ||
| - path: "**/*.md" | ||
| instructions: | | ||
| "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness" | ||
| - path: ".changelog/*" | ||
| instructions: | | ||
| "Assess the changes in the changelog for correctness and completeness, particularly flagging missing changes" | ||
| auto_review: | ||
| enabled: true | ||
| ignore_title_keywords: | ||
| - "WIP" | ||
| - "DO NOT MERGE" | ||
| drafts: false | ||
| base_branches: | ||
| - "main" | ||
| - "feat/*" | ||
| - "release/*" | ||
| chat: | ||
| auto_reply: true | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean it won't act on drafts before they are "ready for review"?
If yes, it might make sense to change this. If we had coderabbit comments already in the draft, we could apply its suggestions before publishing it for review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's right. I think it's sufficient to get automatic comments when you put it out of draft; my fear is that it spams draft PRs with dozens of comments that you are aware of.
afaict you can get it to review outside of the auto-review guidelines by commenting @CodeRabbit review
(see the tips that are collapsed at the bottom of its review)