Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: upgrade PSS to SDK v0.50.x (ICS v4.3.x features only) #1996

Merged
merged 62 commits into from
Jul 2, 2024

nits

85aabd0
Select commit
Loading
Failed to load commit list.
Merged

chore!: upgrade PSS to SDK v0.50.x (ICS v4.3.x features only) #1996

nits
85aabd0
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL succeeded Jun 28, 2024 in 3s

4 new alerts

New alerts in code changed by this pull request

  • 4 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 162 in x/ccv/provider/keeper/validator_set_update.go

See this annotation in the file changed.

Code scanning / CodeQL

Useless assignment to local variable Warning

This definition of err is never used.

Check warning on line 172 in x/ccv/provider/module.go

See this annotation in the file changed.

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
path flow from Begin/EndBlock to a panic call

Check warning on line 87 in x/ccv/provider/keeper/validator_set_update.go

See this annotation in the file changed.

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

Possible panics in BeginBock- or EndBlock-related consensus methods could cause a chain halt

Check warning on line 115 in tests/e2e/state.go

See this annotation in the file changed.

Code scanning / CodeQL

Iteration over map Warning test

Iteration over map may be a possible source of non-determinism