Remove spm

[faddat]

Description

This PR removes SPM.

Linked issues

Closes: #753

Type of change

If you've checked more than one of the first three boxes, consider splitting this PR into multiple PRs!

• Feature: Changes and/or adds code behavior, irrelevant to bug fixes
• Fix: Changes and/or adds code behavior, specifically to fix a bug
• Refactor: Changes existing code style, naming, structure, etc.
• Testing: Adds testing
• Docs: Adds documentation

Regression tests

If Refactor, describe the new or existing tests that verify no behavior was changed or added where refactors were introduced.

New behavior tests

If Feature or Fix, describe the new or existing tests that verify the new behavior is correct and expected.

Versioning Implications

• This PR will affect semantic versioning as defined for ICS

If the above box is checked, which version should be bumped?

• MAJOR: Consensus breaking changes to both the provider and consumers(s), including updates/breaking changes to IBC communication between provider and consumer(s)
• MINOR: Consensus breaking changes which affect either only the provider or only the consumer(s)
• PATCH: Non consensus breaking changes

Targeting

Please select one of the following:

• This PR is only relevant to main
• This PR is relevant to main, and should also be back-ported to ____ (ex: v1.0.0 and v1.1.0)
• This PR is only relevant to ____ (ex: v1.0.0, v1.1.0, and v1.2.0)

[faddat]

spm Taints every consumer chain with known bad software

[faddat]

nothing should ship without this, because if there are ever "strange issues that are hard to explain" -- this would be leading candidate.

[jtremback]

LGTM

[shaspitz]

Couple of clarification questions but nothing seemed dangerous, LGTM

[shaspitz]

Why does this PR add functions that are marked as depreciated? Did this code already exist in some form?

[faddat]

I copied it out of the last SPM removal I did with my own two hands.

[faddat]

but -- to be clear, this is a deprecated way to do things and we have been trying to pull this out of the sdk for ages.

[faddat]

this is a shim due to the design of ics

[shaspitz]

Are these comments still relevant to the ICS repo?

[faddat]

here, let's improve all this a bit

[shaspitz]

Same question as above

[faddat]

this is a shim due to the design of ics

[shaspitz]

same question as above

[faddat]

this is a shim due to the design of ics

[faddat]

the pull request removes spm, which is dangerous thanks

[faddat]

the code exists in the params folder too. For some reason it did not work when I tried that. So I put it in app.go, same as Marius did

interchain-security/x/ccv/consumer/app/app.go

Lines 772 to 792 in c0124d8

	// MakeTestEncodingConfig creates an EncodingConfig for testing. This function
	// should be used only in tests or when creating a new app instance (NewApp*()).
	// App user shouldn't create new codecs - use the app.AppCodec instead.
	// [DEPRECATED]
	func MakeTestEncodingConfig() appparams.EncodingConfig {
	encodingConfig := appparams.MakeTestEncodingConfig()
	std.RegisterLegacyAminoCodec(encodingConfig.Amino)
	std.RegisterInterfaces(encodingConfig.InterfaceRegistry)
	ModuleBasics.RegisterLegacyAminoCodec(encodingConfig.Amino)
	ModuleBasics.RegisterInterfaces(encodingConfig.InterfaceRegistry)
	return encodingConfig
	}
	// EncodingConfig specifies the concrete encoding types to use for a given app.
	// This is provided for compatibility between protobuf and amino implementations.
	type EncodingConfig struct {
	InterfaceRegistry types.InterfaceRegistry
	Marshaler codec.Codec
	TxConfig client.TxConfig
	Amino *codec.LegacyAmino
	}

[faddat]

but @smarshall-spitzbart sir you are correct that is a really unusual place for those things!

[faddat]

ah right that's what happened.

I prefer the prior version. Tests work.

[faddat]

Interestingly, even Marius's own team noted the bug that was copied into the SPSP branch