Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: buf.yaml should specify the repository #872

Merged
merged 3 commits into from
May 2, 2023
Merged

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Apr 21, 2023

Description

nit: name the buf module.

Previous state

# This module represents the "proto" root found in
# the previous configuration.
version: v1
name: buf.build/cosmos/cosmos-sdk
deps:
  - buf.build/cosmos/gogo-proto
  - buf.build/googleapis/googleapis

new state

# This module represents the "proto" root found in
# the previous configuration.
version: v1
name: buf.build/cosmos/interchain-security
deps:
  - buf.build/cosmos/gogo-proto
  - buf.build/googleapis/googleapis

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API or client breaking change
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

name the buf module
@faddat faddat changed the title fix: Update buf.yaml fix: buf.yaml should specify the repository Apr 29, 2023
@faddat

This comment was marked as off-topic.

@jtremback
Copy link
Contributor

What effect does this change have?

@faddat
Copy link
Contributor Author

faddat commented May 1, 2023

It correctly specifies the repository. the repository is specified incorrectly. We were to try to publish to the buf registry, we would find that it does not work because we would be trying to publish to the cosmos SDK buf registry.

Copy link
Contributor

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for your contribution @faddat.

@mmulji-ic mmulji-ic merged commit 4fb6f75 into cosmos:main May 2, 2023
@faddat

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants