Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use go 1.19 #899

Merged
merged 2 commits into from
Apr 27, 2023
Merged

chore: use go 1.19 #899

merged 2 commits into from
Apr 27, 2023

Conversation

shaspitz
Copy link
Contributor

@shaspitz shaspitz commented Apr 27, 2023 •
edited by jtremback
Loading

Description

At present we need go1.19 for our proto files to build correctly.

Using go 1.20 produces problems during the proto build.

make proto-gen
Generating Protobuf files
Generating gogo proto code
invalid value "1.20" for flag -compat: maximum supported Go version is 1.19
usage: go mod tidy [-e] [-v] [-go=version] [-compat=version]
Run 'go help mod tidy' for details.
make: *** [proto-gen] Error 2

This change will be reverted in a future step where we upgrade to go1.20, bump ghcr.io/cosmos/proto-builder to >=0.11.5 to facilitate building using cosmos/proto.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API or client breaking change
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry to CHANGELOG.md
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

@shaspitz shaspitz marked this pull request as ready for review April 27, 2023 17:12
shaspitz
shaspitz commented Apr 27, 2023
View reviewed changes
x/ccv/provider/keeper/key_assignment_test.go
@@ -47,7 +47,7 @@ func TestGetAllValidatorConsumerPubKey(t *testing.T) {
pk, ctx, ctrl, _ := testkeeper.GetProviderKeeperAndCtx(t, testkeeper.NewInMemKeeperParams(t))
defer ctrl.Finish()

rand.Seed(time.Now().Unix()) // nolint:staticcheck // ignore SA1019 for tests
rand.Seed(time.Now().Unix())
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This diff is neccessary because the linter has different functionality when using go 1.19 vs 1.20

jtremback
jtremback approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@jtremback jtremback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval

MSalopek
MSalopek approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@MSalopek MSalopek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval.

I opened a chore issue to bump go to 1.20 and proto-builder to >=0.11.5

@shaspitz shaspitz merged commit 514e525 into main Apr 27, 2023
@shaspitz shaspitz deleted the shawn/go-1.19 branch April 27, 2023 17:41
@mpoke mpoke mentioned this pull request May 16, 2023
Merged
18 tasks
@shaspitz shaspitz mentioned this pull request May 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSalopek MSalopek MSalopek approved these changes

@jtremback jtremback jtremback approved these changes

@mpoke mpoke Awaiting requested review from mpoke

@sainoe sainoe Awaiting requested review from sainoe

@mmulji-ic mmulji-ic Awaiting requested review from mmulji-ic

@glnro glnro Awaiting requested review from glnro

@yaruwangway yaruwangway Awaiting requested review from yaruwangway

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaspitz @jtremback @MSalopek