-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: amino encoding registration for multisig #911
Conversation
LGTM |
@smarshall-spitzbart can we add an automated test that checks this is ok? |
yes, need to get this PR working in docker first |
@@ -11,6 +12,7 @@ import ( | |||
// RegisterLegacyAminoCodec registers the necessary x/ibc transfer interfaces and concrete types | |||
// on the provided LegacyAmino codec. These types are used for Amino JSON serialization. | |||
func RegisterLegacyAminoCodec(cdc *codec.LegacyAmino) { | |||
cdc.RegisterConcrete(&MsgAssignConsumerKey{}, "ccv/MsgAssignConsumerKey", nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cdc.RegisterConcrete(&MsgAssignConsumerKey{}, "ccv/MsgAssignConsumerKey", nil) | |
cdc.RegisterConcrete(&MsgAssignConsumerKey{}, "/interchain_security.ccv.provider.v1.MsgAssignConsumerKey", nil) |
should we use full path here?
Closing in favor of #916. If this PR were to fix the issue, it would be the more elegant solution, unfortunately I couldn't get it to work |
Description
Fixes errors seen in testnet and prod where multisig would return errors like
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change