Increase coin denom maxsize in order to support transactions with IBC tokens #56
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, signing any transaction with an ibc token results in unrecognized error code due to the current coin denom maxsize validation of 50 characters including the null byte.
IBC denoms, such as
ibc/27394FB092D2ECCD56123C74F36E4C1F926001CEADA9CA97EA622B25F41E5EB2
, are 68 characters in length, and the cosmos-sdk supports denominations up to 128 characters in length.Changes
This PR adds a failing test with an example transaction containing an ibc denom, and then increases the denom max length to 129 (128 characters + null byte) to pass the test.
Testing
make cpp_test
andmake zemu_test
both passed locally.I also used
make load
and tested I was able to successfully sign transactions with ibc denoms on the command line and from the browser with this PR.