Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep session per network instead of signing users out when switching networks #3314

Closed
jbibla opened this issue Dec 15, 2019 · 6 comments · Fixed by #3336
Closed

keep session per network instead of signing users out when switching networks #3314

jbibla opened this issue Dec 15, 2019 · 6 comments · Fixed by #3336
Assignees

Comments

@jbibla
Copy link
Collaborator

jbibla commented Dec 15, 2019

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context

@Bitcoinera
Copy link
Contributor

I see this tightly related to #3200
It is about the same, changing the way we store the sessions to do it by network.

Good point. By implementing sessions this way we don't need to sign users out anymore 👍

@jbibla
Copy link
Collaborator Author

jbibla commented Dec 16, 2019

ok nice! didn't see that one!

yep, very closely related.

though, i think it's important to show all the previously used addresses - when you select the regen one or cosmos one it should change networks for the user 😄

@faboweb
Copy link
Collaborator

faboweb commented Dec 18, 2019

It is about the same, changing the way we store the sessions to do it by network.

Hmmm. Have you considered, that they need to be stored separately? All sessions (even per network) and the session that you are signed in with per network.

@Bitcoinera
Copy link
Contributor

It is about the same, changing the way we store the sessions to do it by network.

Hmmm. Have you considered, that they need to be stored separately? All sessions (even per network) and the session that you are signed in with per network.

🤔 Mmm, and in this PR you took care of the the sessions you are currently signed in, but not the rest?

@faboweb
Copy link
Collaborator

faboweb commented Dec 20, 2019

exactly. we thought we want to keep sessions in general for the (last addresses used). not per network.

@faboweb
Copy link
Collaborator

faboweb commented Dec 20, 2019

we still need to switch networks based on these addresses though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants