Skip to content

Commit

Permalink
Fix the test-gaia scripts (#359)
Browse files Browse the repository at this point in the history
* attempt to fix tests

* reupload image

* Try with cosmwasm gaia

* Change expected client type in tests

* Disable akash tests until they have a new image

* 2nd attempt to disable akash tests

* Update test/test_chains.go

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>

Co-authored-by: Colin Axnér <25233464+colin-axner@users.noreply.github.com>
  • Loading branch information
ethanfrey and colin-axner committed Jan 12, 2021
1 parent 1daec66 commit e24e01b
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 8 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/akash-tests.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
name: TESTING - akash to gaia integration

on:
pull_request:
push:
branches:
- master
- disabled_until_new_akash_build

jobs:
build:
Expand Down
5 changes: 3 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
VERSION := $(shell echo $(shell git describe --tags) | sed 's/^v//')
COMMIT := $(shell git log -1 --format='%H')
SDKCOMMIT := $(shell go list -m -u -f '{{.Version}}' github.com/cosmos/cosmos-sdk)
GAIA_VERSION := jack/gaiav3.0
GAIA_VERSION := main
AKASH_VERSION := jack/update-sdk
all: ci-lint install

Expand Down Expand Up @@ -50,7 +50,8 @@ test-gaia:
@TEST_DEBUG=true go test -mod=readonly -v ./test/... -run TestGaia*

test-akash:
@TEST_DEBUG=true go test -mod=readonly -v ./test/... -run TestAkash*
@echo Temporarily Disabled
# @TEST_DEBUG=true go test -mod=readonly -v ./test/... -run TestAkash*

coverage:
@echo "viewing test coverage..."
Expand Down
9 changes: 6 additions & 3 deletions test/test_chains.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,16 @@ import (
)

var (
// GAIA BLOCK TIMEOUTS on jackzampolin/gaiatest:master
// GAIA BLOCK TIMEOUTS are located in the single node setup script on gaia
// https://github.com/cosmos/gaia/blob/main/contrib/single-node.sh
// timeout_commit = "1000ms"
// timeout_propose = "1000ms"
// 3 second relayer timeout works well with these block times
gaiaTestConfig = testChainConfig{
dockerImage: "jackzampolin/gaiatest",
dockerTag: "jack_gaiav3.0",
// This is built from contrib/Dockerfile.test of this PR:
// https://github.com/CosmWasm/gaia/tree/ethanfrey/docker-test-fixes
dockerImage: "cosmwasm/gaiatest",
dockerTag: "v3.0.0",
timeout: 3 * time.Second,
rpcPort: "26657",
accountPrefix: "cosmos",
Expand Down
2 changes: 1 addition & 1 deletion test/test_queries.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func testClient(t *testing.T, src, dst *ry.Chain) {
require.NotNil(t, client)
cs, err := clientypes.UnpackClientState(client.ClientState)
require.NoError(t, err)
require.Equal(t, cs.ClientType(), "Tendermint")
require.Equal(t, cs.ClientType(), "07-tendermint")
}

// testConnectionPair tests that the only connection on src and dst is between the two chains
Expand Down

0 comments on commit e24e01b

Please sign in to comment.