Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY connection/channel updates #422

Closed
colin-axner opened this issue Feb 11, 2021 · 0 comments · Fixed by #424
Closed

DRY connection/channel updates #422

colin-axner opened this issue Feb 11, 2021 · 0 comments · Fixed by #424
Labels
good first issue Good for newcomers

Comments

@colin-axner
Copy link
Contributor

Now that chain.UpdateClient does all updating functionality. I'm pretty sure we can reduce several lines of code by calling src.UpdateClient and dst.UpdateClient in the beginning of connection/channel handshakes and using those messages when necessary. To fix this issue, simply construct the update message for src and dst once, at the top of ExecuteConnection(Channel)Handshake, and pass those into Initialize, and use the constructed messages instead of creating one in each switch statement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant