DRY handshake code #424
Merged
DRY handshake code #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2021
|
a more comprehensive fix should be done in #425 |
AdityaSripal
approved these changes
Feb 12, 2021
Comment on lines
-566
to
+565
| updateMsg, err := dst.UpdateClient(src) | ||
| updateMsg, err := src.UpdateClient(dst) |
There was a problem hiding this comment.
yes pretty sure. The logic doesn't hold since if you look at the code, this message is beings added to msgs.Src
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #422
I believe this fixes a bug where the handshake proof relies on a consensus state not being committed via an update message