Remove IBC-Go versioning table on home readme #1047
Conversation
boojamya
requested review from
jackzampolin,
jtieri and
mark-rushakoff
as code owners
| @mkdir -p ./chain-code/ | ||
| @git clone --branch $(GAIA_VERSION) --depth=1 https://github.com/cosmos/gaia.git ./chain-code/gaia | ||
| @mkdir -p $(CHAIN_CODE)/ | ||
| @git clone --branch $(GAIA_REPO) --depth=1 https://github.com/cosmos/gaia.git $(GAIA_REPO) | ||
|
|
||
| build-gaia: |
There was a problem hiding this comment.
since we removed the legacy tests in favor of the ibctest cases, are these relevant to the repo anymore?
There was a problem hiding this comment.
To my knowledge they are only used if people try and run the dev-env script in examples/demo
If the gaiad binary doesn't exists, it will recommend you run 'make build-gaia'
There was a problem hiding this comment.
Could also remove these make commands and add a small blurb in the demo readme on how to download and build Gaia.
There was a problem hiding this comment.
maybe we should replace the demo examples with ibctest examples? Seems fine to keep this for now though. Thanks for fixing!
There was a problem hiding this comment.
Yes, however the current demos are such an easy example showing the basics of relaying and IBC. ibctest adds a another level complexity.
For that reason, I'm in favor of keeping the demos in.
Now that we are several releases into Relayer V2, it shouldn't be necessary to maintain the IBC-Go versioning table in the readme anymore.
This PR also...
make-gaia, andbuild-gaiaCloses #1041, #871