Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add commit var and update to go 1.19 #1064

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Add commit var and update to go 1.19 #1064

merged 1 commit into from
Dec 15, 2022

Conversation

agouin
Copy link
Member

@agouin agouin commented Dec 14, 2022

Before:

Release bin:

$ rly version                 
version: v2.2.0-rc3
commit: unknown
cosmos-sdk: v0.46.6
go: go1.18.3 linux/amd64

Docker image:

$ docker run -it --rm --entrypoint rly ghcr.io/cosmos/relayer:v2.2.0-rc3 version
version: 2.2.0-rc3
commit: unknown
cosmos-sdk: v0.46.6
go: go1.19.4 linux/amd64

After:

Release bin:

$ rly version
version: 2.2.0-rc3
commit: 284129917a0d1a2c5a63d8e51057a9271cd94deb
cosmos-sdk: v0.46.6
go: go1.19.4 linux/amd64

Docker image:

$ docker run -it --rm --entrypoint rly relayer:fix_commit version
version: 2.2.0-rc3
commit: 284129917a0d1a2c5a63d8e51057a9271cd94deb
cosmos-sdk: v0.46.6
go: go1.19.4 linux/amd64

boojamya
boojamya approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@boojamya boojamya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dirty in a good way.

@agouin agouin merged commit 1b0e771 into main Dec 15, 2022
@agouin agouin deleted the andrew/commit_and_go1.19 branch December 15, 2022 00:20
agouin added a commit that referenced this pull request Dec 15, 2022
@agouin
Add commit var and update to go 1.19 (#1064)
3e3ef1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boojamya boojamya boojamya approved these changes

@jackzampolin jackzampolin Awaiting requested review from jackzampolin

@jtieri jtieri Awaiting requested review from jtieri

@mark-rushakoff mark-rushakoff Awaiting requested review from mark-rushakoff

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agouin @boojamya