Stride ICQ

[agouin]

Continuation of #954. Most of the commits there have been merged into main as this functionality was being implemented.

Implements Stride's ICQ implementation, which consists of:

• tendermint events on stride chain declare intent for query request
• relayer executes query request on counterparty chain
• query response, with proof included, is bundled into a MsgSubmitQueryResponse message
• relayer submits this message in a transaction to stride chain along with a prepended MsgUpdateClient

The relayer handles correlation of client ICQ messages in the PathProcessor in a similar way as the handshake and packet flow messages.

Brings in proto-gen capabilities, required for generating the MsgSubmitQueryResponse protos to use it as a cosmos Msg.

This removes the dependency on the stride repository, and in doing so removes the need for ibc-go to be on the same major version (and potentially other deps).

This allows Stride's ICQ implementation to exist in the relayer without impact, other than len checks, for relaying non-Stride.

[jtieri]

I went through this and compared a lot of the new code relevant to ICQ to other components that operate mostly the same (e.g. the client and packet messages/caches) and everything looked good. Couple comments but nothing major.

Do we have test cases for this ICQ implementation in ibctest? If so, would it be favorable to bring them in so we can also run those in CI? With this being a new major feature I think it would be nice to have some test coverage somewhere.

[agouin]

Do we have test cases for this ICQ implementation in ibctest? If so, would it be favorable to bring them in so we can also run those in CI? With this being a new major feature I think it would be nice to have some test coverage somewhere.

Yes, the test exists in strangelove-ventures/interchaintest#273, but it tests more than is required here. I brought in the ICQ test and slimmed it down to a single validator for the relayer.

[jtieri]

Do we have test cases for this ICQ implementation in ibctest? If so, would it be favorable to bring them in so we can also run those in CI? With this being a new major feature I think it would be nice to have some test coverage somewhere.

Yes, the test exists in strangelove-ventures/interchaintest#273, but it tests more than is required here. I brought in the ICQ test and slimmed it down to a single validator for the relayer.

Thanks for that! Adds some peace of mind that future changes to the relayer won't break support for this feature.