Penumbra support v2 #1144

hdevalence · 2023-03-24T19:10:47Z

Replaces #1124 but from the Penumbra fork to make collaboration easier

remove copied-over cosmos provider tests, rename processor cosmos -> penumbra rename ccp -> pcp reformat into new relayer dir structure update penumbra types to point to buf.build building again

wip: unbase64? wip: multiple messages per penumbra tx wip: stub SendMessages impl wip: attempt to split out common method wip: use random anchor and work around path renaming wip: improve logging wip: changes during pairing https://www.youtube.com/watch?v=RYonSOkZ5ZE clean up logs skip height bug workaround drop debug panic

…sing

conorsch · 2023-03-30T23:11:56Z

Using the latest code in this branch, along with the configs in https://github.com/penumbra-zone/penumbra/tree/fa2f750f4ec049bc0d7195dc368fc7490f5c347e/deployments/relayer , we're able to build a working path:

❯ rly paths list
 0: penumbra_path        -> chns(✔) clnts(✔) conn(✔) (penumbra-testnet-pasiphae<>penumbra-testnet-pasiphae-5d99ea66)

jtieri

great work penumbra team 🔥 🔥
just a handful of nits but otherwise this lgtm

jtieri · 2023-03-31T15:41:14Z

relayer/client.go

@@ -510,6 +510,7 @@ func findMatchingClient(ctx context.Context, src, dst *Chain, newClientState ibc
 // parseClientIDFromEvents parses events emitted from a MsgCreateClient and returns the
 // client identifier.
 func parseClientIDFromEvents(events []provider.RelayerEvent) (string, error) {
+	fmt.Printf("client.go events: %+v\n", events)


looks like an artifact from debugging, this could be removed

jtieri · 2023-03-31T15:41:38Z

relayer/channel.go

@@ -74,7 +74,7 @@ func (c *Chain) CreateOpenChannels(
 			dst.chainProcessor(c.log, nil),
 		).
 		WithPathProcessors(pp).
-		WithInitialBlockHistory(0).
+		WithInitialBlockHistory(100).


is there a specific reason for this change?

jtieri · 2023-03-31T15:42:17Z

relayer/events.go

+// ParseConnectionIDFromEvents parses events emitted from a MsgConnectionOpenInit or
+// MsgConnectionOpenTry and returns the connection identifier.
+func ParseConnectionIDFromEvents(events []provider.RelayerEvent) (string, error) {
+	fmt.Printf("events.go events: %+v\n", events)


another print statement that could go

jtieri · 2023-03-31T15:43:46Z

relayer/chains/penumbra/penumbra_chain_processor.go

+	"github.com/cosmos/relayer/v2/relayer/processor"
+	"github.com/cosmos/relayer/v2/relayer/provider"
+
+	//	jsonrpcclient "github.com/cometbft/cometbft/rpc/jsonrpc/client"


commented import statement could be removed

jtieri · 2023-03-31T15:56:16Z

relayer/chains/penumbra/penumbra_chain_processor.go

+}
+
+/*
+func (pcp *PenumbraChainProcessor) queryCycle(ctx context.Context, persistence *queryCyclePersistence) error {


if this is no longer being used as a reference we could pull this out

jtieri · 2023-03-31T15:57:26Z

relayer/chains/penumbra/tx.go

+func parseEventsFromABCIResponse(resp abci.ResponseDeliverTx) []provider.RelayerEvent {
+	var events []provider.RelayerEvent
+
+	fmt.Printf("tx.go events: %+v\n", resp.Events)


another print statement that could be removed

jtieri · 2023-03-31T15:57:37Z

relayer/chains/penumbra/tx.go

+			Attributes: attributes,
+		})
+	}
+	fmt.Printf("parsed events: %+v\n", events)


here as well

jtieri · 2023-03-31T15:59:36Z

relayer/chains/penumbra/tx.go

+	if err != nil {
+		return nil, false, err
+	}
+	cc.log.Info("waiting for penumbra tx to commit", zap.String("syncRes", fmt.Sprintf("%+v", syncRes)))


can we capitalize the first word in this log statement? for reference we do have a style guide for logging which can be found here

jtieri · 2023-03-31T15:59:49Z

relayer/chains/penumbra/tx.go

+		if err != nil {
+			return err
+		}
+		cc.log.Info("got penumbra tx result", zap.String("res", fmt.Sprintf("%+v", res)))


See above comment

jtieri · 2023-03-31T16:01:24Z

relayer/chains/penumbra/tx.go

+var defaultUpgradePath = []string{"upgrade", "upgradedIBCState"}
+
+/*
+fn apphash_spec() -> ics23::ProofSpec {


this looks like it was being used to port some Rust code but if it's no longer needed it could be removed

Responding to review comments, honoring the style guide for logging, and removing some unused reference code that was commented out while debugging.

conorsch · 2023-03-31T17:03:59Z

Thanks for pointing me to the style guide, @jtieri. I've updated all the places you called out, and touched up a few more logging statements to be compliant. After making these changes, I rebuilt and reran the path build script, to ensure I didn't inadventerntly break something. Indeed, we're still good:

❯ rly paths list
 0: penumbra_path        -> chns(✔) clnts(✔) conn(✔) (penumbra-testnet-pasiphae<>penumbra-testnet-pasiphae-7549032f)

jtieri

🚢 🚢

This reverts commit c687408.

* Flush query should include begin and end block events (cosmos#1125) * Include begin and end block events * disable flushing when termination condition is set * Still flush for FlushLifecycle * Add sort for flush logging to avoid confusion * pre_init messages (cosmos#1131) * Wire initial messages into path processor caches so that retry logic will occur * Fix counterparty keys * Remove debug log * fix default coin type (cosmos#1134) * fix slip44 default * Add test case * build: bump to Go 1.20 + bump deps (cosmos#1132) * build: bump to Go 1.20 + bump deps This bumps the Go version to 1.20 and also bumps the SDK version to 0.47.0 and ibc-go to v7.0.0 * chore: update GH workflows to use Go 1.20 + update interchaintest deps * chore: update missing deps in go.sum + use 1.20 in dockerfiles * chore: bump to `setup-go/v4` and remove caching step * chore: bump to `checkout/v3` and remove caching step * chore: bump 1.20.2 * Fix flushing acks (cosmos#1139) * Fix ordered channel closure (cosmos#1142) * Fix ordered channel closure * Increase timeout for scenarios test * Fix tracking of init messages when IDs aren't the same * bump interchaintest to include explicit port bindings * Fix flush termination condition (cosmos#1141) * bump to main sha (cosmos#1143) * Pre-filter flush channels (cosmos#1146) * Add channel close correlation (cosmos#1145) * Add channel close correlation * Switch to pre-close key * make tx channel-close cli command work, add test coverage * more sweet code removals * update comment * Fix flush on ordered channels (cosmos#1150) * Fix flush on ordered channels * Queue all packets at nextseqrecv or above * Now that we have periodic flushing, skip blocks if they can't be queried (cosmos#1154) * Lock config file for all write operations (cosmos#1156) * Lock config file for all write operations * Fix linter errs * tidy * more tidy * Penumbra support v2 (cosmos#1144) * Penumbra buf go gen * Use go prefix override * wip: penumbra relayer provider remove copied-over cosmos provider tests, rename processor cosmos -> penumbra rename ccp -> pcp reformat into new relayer dir structure update penumbra types to point to buf.build building again * fix penumbra * fix: implement MsgSubmitMisbehaviour * fix: remove unnecessary proto file + fix msg type cast * chore: add removal of penumbra client protos in protocgen * working penumbra relayer functionality wip: unbase64? wip: multiple messages per penumbra tx wip: stub SendMessages impl wip: attempt to split out common method wip: use random anchor and work around path renaming wip: improve logging wip: changes during pairing https://www.youtube.com/watch?v=RYonSOkZ5ZE clean up logs skip height bug workaround drop debug panic * update penumbra chain processor connection and channel message processing * cleanup logging statements for review Responding to review comments, honoring the style guide for logging, and removing some unused reference code that was commented out while debugging. --------- Co-authored-by: Andrew Gouin <andrew@gouin.io> Co-authored-by: Ava Howell <ava@penumbra.zone> Co-authored-by: jtieri <justin@thetieris.com> Co-authored-by: Ava Howell <ava@avahowell.me> Co-authored-by: Conor Schaefer <conor@penumbralabs.xyz> Co-authored-by: Justin Tieri <37750742+jtieri@users.noreply.github.com> * --time-threshold example use cases (cosmos#1155) * Make ICA waits more explicit (cosmos#1157) * Make ICA waits more explicit * poll for timeout * poll for channel close confirm * Comment out sqlite db file for scenarios tests * Bump github.com/docker/docker in /interchaintest (cosmos#1160) Bumps [github.com/docker/docker](https://github.com/docker/docker) from 20.10.19+incompatible to 20.10.24+incompatible. - [Release notes](https://github.com/docker/docker/releases) - [Commits](moby/moby@v20.10.19...v20.10.24) --- updated-dependencies: - dependency-name: github.com/docker/docker dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * bump version in docs (cosmos#1158) * Bump github.com/opencontainers/runc in /interchaintest (cosmos#1153) Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.1.3 to 1.1.5. - [Release notes](https://github.com/opencontainers/runc/releases) - [Changelog](https://github.com/opencontainers/runc/blob/v1.1.5/CHANGELOG.md) - [Commits](opencontainers/runc@v1.1.3...v1.1.5) --- updated-dependencies: - dependency-name: github.com/opencontainers/runc dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Gouin <andrew@gouin.io> * Fix QueryConnectionsUsingClient for cosmos (cosmos#1162) * Make min query loop duration configurable (cosmos#1164) * penumbra provider: update generated protos (cosmos#1168) * Add sr25519 support (cosmos#1120) * Migrate to cometbft * Additional replaces * Register comet proto types * Add sr25519 support * bump ictest * Add keys test * Update supported algos comment * penumbra: update protos (cosmos#1170) Updating the generated protos for Penumbra support. After lightly editing the `scripts/protocgen.sh` script, I ran `make proto-gen` and then committed the changes `relayer/chains/penumbra/`. Other automatically updated protos I intentionally excluded from this PR, to avoid side-effects. Co-authored-by: Conor Schaefer <conor@penumbralabs.xyz> * chore: add path name to logs in message processor (cosmos#1171) * Fix multiple conn open init (cosmos#1173) * allow register with extra_codecs (cosmos#1175) * Harry/fee middleware (cosmos#1174) * Register Counterparty relayer cmd and fee middleware test * debugging the command * debugging and finalizing the fee_middleware_test. * debugging and finalizing the fee_middleware_test. * merged with updated repo * clear out some commanded code * nits and suggestions post review * more nits * added one val no fullnode as chainspec --------- Co-authored-by: Harry <harrycosmos@Harrys-MacBook-Pro.local> * fix: nil receiver initiate for path (cosmos#1177) * fix nil receiver initiate for path ensure path get written to config * add change doc * feat: add max-gas-amount parameter in chain configs (cosmos#1178) * add max fee * add test * add change doc * Update cregistry/chain_info.go * dep: bump sdk from v0.47.0 to v0.47.2 (cosmos#1180) * bump sdk from v0.47.0 to v0.47.2 fix btcutil dep * fix dep of hdkeychain * Harry/rly tx channel (cosmos#1183) * made a new method "logChannelOpenMessage" to log the newly opened channel into info level * added fields * some changes --------- Co-authored-by: Harry <harrycosmos@Harrys-MacBook-Pro.local> * Harry/rly tx transfer (cosmos#1184) * made a new method "logChannelOpenMessage" to log the newly opened channel into info level * added fields * some changes * recreated issue 1151, added logs --------- Co-authored-by: Harry <harrycosmos@Harrys-MacBook-Pro.local> Co-authored-by: Andrew Gouin <andrew@gouin.io> * Better Error Messaging when failing to query the Block Height (cosmos#1189) * better block data errors * remove redundant field * penumbra: update protos (cosmos#1181) Matches the latest protos shipped with the Penumbra Testnet 52. Co-authored-by: Conor Schaefer <conor@penumbralabs.xyz> Co-authored-by: Justin Tieri <37750742+jtieri@users.noreply.github.com> * Neutron launch fixes and optimizations (cosmos#1185) * pipe max msgs through path processor * only apply max msgs to packet msgs * multiple msgs simultaneously on ordered chans * flush should be more frequent if it fails or does not complete * fix legacy * handle feedback * Problem: fixes in ibc-go v7.0.1 are not included (cosmos#1205) * Problem: fixes in ibc-go v7.0.1 are not included * add change doc * Harry/rly address (cosmos#1204) * added addresCmd to root and keys.go * nicks * nick * made a common method "showAddressByChainAndKey" to be used by both addressCmd and keysShowCmd --------- Co-authored-by: Harry <harrycosmos@Harrys-MacBook-Pro.local> Co-authored-by: Andrew Gouin <andrew@gouin.io> * deps: update to ibc-go v7.1.0-rc0 (cosmos#1207) * Export wallet address for Prometheus metrics (cosmos#1206) * export relayer address for pro * address in updateFeesSpent * make error messages consistent * log error rather than return * handle 0 balance * chore: fix issue * fix: connection key include * chore: comment out flush * fix: remove SET method from providerConfig * chore: replace static naming with constant * chore: packet timeout after relayer update --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Andrew Gouin <andrew@gouin.io> Co-authored-by: Justin Tieri <37750742+jtieri@users.noreply.github.com> Co-authored-by: Henry de Valence <hdevalence@hdevalence.ca> Co-authored-by: Ava Howell <ava@penumbra.zone> Co-authored-by: jtieri <justin@thetieris.com> Co-authored-by: Ava Howell <ava@avahowell.me> Co-authored-by: Conor Schaefer <conor@penumbralabs.xyz> Co-authored-by: Dan Kanefsky <56059752+boojamya@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Conor Schaefer <conorsch@users.noreply.github.com> Co-authored-by: mmsqe <tqd0800210105@gmail.com> Co-authored-by: Cosmos-Harry <110472914+Cosmos-Harry@users.noreply.github.com> Co-authored-by: Harry <harrycosmos@Harrys-MacBook-Pro.local> Co-authored-by: mmsqe <mavis@crypto.com> Co-authored-by: Keefer Taylor | Tessellated <keefer@tessellated.io> Co-authored-by: izyak <test@test.com> Co-authored-by: viveksharmapoudel <viveksharmapoudel@gmail.com>

Penumbra (non-`cosmos-SDK`) support was added to the go-relayer in cosmos/relayer#1144 on March 31, 2023.

agouin mentioned this pull request Mar 24, 2023

Penumbra support #1124

Closed

hdevalence force-pushed the penumbra-v2 branch from 8caa3cc to bdc0db1 Compare March 24, 2023 19:57

This was referenced Mar 25, 2023

Tracking issue: MVP IBC Relayer infrastructure penumbra-zone/penumbra#465

Closed

Determine the cause of ICS23 verification failures in ConnectionOpenAck handling penumbra-zone/penumbra#2252

Closed

hdevalence force-pushed the penumbra-v2 branch from fa044be to 23f7ef4 Compare March 29, 2023 00:24

avahowell force-pushed the penumbra-v2 branch from f573547 to 9f02511 Compare March 29, 2023 00:46

agouin and others added 9 commits March 29, 2023 17:23

Penumbra buf go gen

5b295b4

Use go prefix override

a2e549c

wip: penumbra relayer provider

9b7d19a

remove copied-over cosmos provider tests, rename processor cosmos -> penumbra rename ccp -> pcp reformat into new relayer dir structure update penumbra types to point to buf.build building again

fix penumbra

ef3285a

fix: implement MsgSubmitMisbehaviour

3b7c6e9

fix: remove unnecessary proto file + fix msg type cast

c1150e7

chore: add removal of penumbra client protos in protocgen

579d929

update penumbra chain processor connection and channel message proces…

e4f17ba

…sing

conorsch force-pushed the penumbra-v2 branch from 9f02511 to e4f17ba Compare March 30, 2023 00:25

hdevalence marked this pull request as ready for review March 30, 2023 00:28

hdevalence requested review from jackzampolin, jtieri, boojamya and mark-rushakoff as code owners March 30, 2023 00:28

This was referenced Mar 30, 2023

WIP: Penumbra Provider penumbra-zone/relayer#1

Closed

wip: penumbra relayer provider penumbra-zone/relayer#2

Closed

jtieri reviewed Mar 31, 2023

View reviewed changes

jtieri approved these changes Mar 31, 2023

View reviewed changes

cleanup logging statements for review

f62ab78

Responding to review comments, honoring the style guide for logging, and removing some unused reference code that was commented out while debugging.

jtieri approved these changes Mar 31, 2023

View reviewed changes

Merge branch 'main' into penumbra-v2

9b1ae88

jtieri enabled auto-merge (squash) March 31, 2023 17:11

jtieri merged commit c687408 into cosmos:main Mar 31, 2023

boojamya added a commit that referenced this pull request Apr 7, 2023

Revert "Penumbra support v2 (#1144)"

7b7e216

This reverts commit c687408.

jonathanpberger added a commit to jonathanpberger/hermes that referenced this pull request Nov 4, 2023

Add Penumbra support to Features Matrix.

d98a9fb

Penumbra (non-`cosmos-SDK`) support was added to the go-relayer in cosmos/relayer#1144 on March 31, 2023.

jonathanpberger mentioned this pull request Nov 4, 2023

Add Penumbra support to Features Matrix. informalsystems/hermes#3685

Merged

romac pushed a commit to informalsystems/hermes that referenced this pull request Nov 9, 2023

Add Penumbra support to Features Matrix. (#3685)

e6a9653

Penumbra (non-`cosmos-SDK`) support was added to the go-relayer in cosmos/relayer#1144 on March 31, 2023.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Penumbra support v2 #1144

Penumbra support v2 #1144

hdevalence commented Mar 24, 2023

conorsch commented Mar 30, 2023

jtieri left a comment

jtieri Mar 31, 2023

jtieri Mar 31, 2023

jtieri Mar 31, 2023

jtieri Mar 31, 2023

jtieri Mar 31, 2023

jtieri Mar 31, 2023

jtieri Mar 31, 2023

jtieri Mar 31, 2023

jtieri Mar 31, 2023

jtieri Mar 31, 2023

conorsch commented Mar 31, 2023

jtieri left a comment

Penumbra support v2 #1144

Penumbra support v2 #1144

Conversation

hdevalence commented Mar 24, 2023

conorsch commented Mar 30, 2023

jtieri left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conorsch commented Mar 31, 2023

jtieri left a comment

Choose a reason for hiding this comment