upgrade deps for cometbft v0.38.0, ibc-go v0.8.0, sdk v0.50.0 and handle breaking changes #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtieri
requested review from
jackzampolin,
boojamya and
mark-rushakoff
as code owners
agouin
approved these changes
Nov 14, 2023
This was referenced Nov 14, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the versions for cometbft, ibc-go and cosmos sdk as well as handling any breaking changes introduced in the process.
cometbft v0.38.0 introduced a breaking change to the returned type from the
BlockResultsRPC call. The issue is better documented in #1273 but essentially due to a change to the field names we end up needing to import a forked version of comet so that we can maintain backwards compatibility with chains running a version older than v0.38.0. The forked repo as well as the branch we are importing can be found hereNote: huge shoutout to @faddat who had started working on upgrading these dependencies and making the necessary adjustments throughout the repo in separate PRs
Edit:
Just waiting on stable releases to be cut for ibc-go and the cosmos sdk before we merge this into main.