fix: add not exist check for loadConfigFile error #1325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmsqe
commented
Nov 9, 2023
mmsqe
requested review from
jackzampolin,
jtieri,
boojamya and
mark-rushakoff
as code owners
jtieri
requested changes
Nov 9, 2023
cmd/appstate.go
Outdated
| @@ -40,7 +40,10 @@ func (a *appState) loadConfigFile(ctx context.Context) error { | |||
|
|
|||
| if _, err := os.Stat(cfgPath); err != nil { | |||
| // don't return error if file doesn't exist | |||
| return nil | |||
| if os.IsExist(err) { | |||
There was a problem hiding this comment.
small nit but the Go docs for IsExists states, "This function predates errors.Is. It only supports errors returned by the os package. New code should use errors.Is(err, fs.ErrExist)."
Could we possibly swap the IsExists call out for errors.Is?
mmsqe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.