Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cmd): make root command publicly accessible #411

Merged
merged 1 commit into from
Feb 5, 2021
Merged

feat(cmd): make root command publicly accessible #411

merged 1 commit into from
Feb 5, 2021

Conversation

ilgooz
Copy link
Contributor

@ilgooz ilgooz commented Feb 5, 2021 •
edited
Loading

so, it can be reused as a sub command by other cobra compatible CLIs. e.g. (starport relayer rly -h)

@ilgooz
feat(cmd): make root command publicly accessible
87d3099 
so, it can be reused as a sub command by other cobra compatible CLIs. e.g. (start relayer rly -h)
ilgooz added a commit to ignite/cli that referenced this pull request Feb 5, 2021
@ilgooz
attach original rly to 'starport relayer rly'
d4450cc 
depends on cosmos/relayer#411.
colin-axner
colin-axner approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colin-axner colin-axner merged commit f4b5685 into cosmos:master Feb 5, 2021
@ilgooz ilgooz deleted the feat/public-root-cmd branch February 5, 2021 10:40
ilgooz added a commit to ignite/cli that referenced this pull request Feb 9, 2021
@ilgooz @lumtis
feat: add standalone relayer commands (#709)
80941cf 
* feat: add standalone relayer commands

* fix linter errs + cosmetics

* rm good old relayer

* fix tests

* rm leftovers from the old relayer

* support Gitpod for faucet discovery

* scaffold: enable faucet by default

* fix Gitpod faucet discovery

* silence relayer so `relayer start` can link multiple chains in parallel
without getting their logs mixed with each other.

undo replace directive in go.mod after
cosmos/relayer#402 has merged.

* link chains in parallel in the relayer start cmd

* docs

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>

* rm faucet.coins_max

* use bob for the faucet

* back to cosmos/relayer

* add cancelation for start cmd

* refactor & add features: relayer commands

* rename `relayer connect` to `relayer configure`.
* rename `relayer start` to `relayer start`.
* auto relay packets between chains via `relayer start` command.
* improve logs/docs show account balances, port and channel ids.
* add gracefull command cancelation.
* only allow to print important relayer logs.
* link and start paths in parallel.

* fix test + lint

* attach original rly to 'starport relayer rly'

depends on cosmos/relayer#411.

* cmd docs

* upgrade relayer

* ensure secure rpc addr always has :443 attached

* rm path from rpc addr

* fix xurl.CleanPath

* fix config

* simplify errors

* inc timeout for integration tests

* fix conflicting statik

* rm parallelism from tests that serves an app

integration tests sometimes fails, this might be due to high cpu usage.
let's see if this will fix it.

* fix install script

* docs

* docs+cosmetics

* add conf alias to config command

* fix docs

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
tbruyelle pushed a commit to tbruyelle/cli-diet that referenced this pull request Oct 17, 2022
@ilgooz @lumtis
feat: add standalone relayer commands (#709)
cbb0952 
* feat: add standalone relayer commands

* fix linter errs + cosmetics

* rm good old relayer

* fix tests

* rm leftovers from the old relayer

* support Gitpod for faucet discovery

* scaffold: enable faucet by default

* fix Gitpod faucet discovery

* silence relayer so `relayer start` can link multiple chains in parallel
without getting their logs mixed with each other.

undo replace directive in go.mod after
cosmos/relayer#402 has merged.

* link chains in parallel in the relayer start cmd

* docs

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>

* rm faucet.coins_max

* use bob for the faucet

* back to cosmos/relayer

* add cancelation for start cmd

* refactor & add features: relayer commands

* rename `relayer connect` to `relayer configure`.
* rename `relayer start` to `relayer start`.
* auto relay packets between chains via `relayer start` command.
* improve logs/docs show account balances, port and channel ids.
* add gracefull command cancelation.
* only allow to print important relayer logs.
* link and start paths in parallel.

* fix test + lint

* attach original rly to 'starport relayer rly'

depends on cosmos/relayer#411.

* cmd docs

* upgrade relayer

* ensure secure rpc addr always has :443 attached

* rm path from rpc addr

* fix xurl.CleanPath

* fix config

* simplify errors

* inc timeout for integration tests

* fix conflicting statik

* rm parallelism from tests that serves an app

integration tests sometimes fails, this might be due to high cpu usage.
let's see if this will fix it.

* fix install script

* docs

* docs+cosmetics

* add conf alias to config command

* fix docs

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Former-commit-id: 80941cfa2a43df15e06176682748aa3967c63d87
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
@ilgooz @lumtis
feat: add standalone relayer commands (ignite#709)
e8e7a40 
* feat: add standalone relayer commands

* fix linter errs + cosmetics

* rm good old relayer

* fix tests

* rm leftovers from the old relayer

* support Gitpod for faucet discovery

* scaffold: enable faucet by default

* fix Gitpod faucet discovery

* silence relayer so `relayer start` can link multiple chains in parallel
without getting their logs mixed with each other.

undo replace directive in go.mod after
cosmos/relayer#402 has merged.

* link chains in parallel in the relayer start cmd

* docs

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>

* rm faucet.coins_max

* use bob for the faucet

* back to cosmos/relayer

* add cancelation for start cmd

* refactor & add features: relayer commands

* rename `relayer connect` to `relayer configure`.
* rename `relayer start` to `relayer start`.
* auto relay packets between chains via `relayer start` command.
* improve logs/docs show account balances, port and channel ids.
* add gracefull command cancelation.
* only allow to print important relayer logs.
* link and start paths in parallel.

* fix test + lint

* attach original rly to 'starport relayer rly'

depends on cosmos/relayer#411.

* cmd docs

* upgrade relayer

* ensure secure rpc addr always has :443 attached

* rm path from rpc addr

* fix xurl.CleanPath

* fix config

* simplify errors

* inc timeout for integration tests

* fix conflicting statik

* rm parallelism from tests that serves an app

integration tests sometimes fails, this might be due to high cpu usage.
let's see if this will fix it.

* fix install script

* docs

* docs+cosmetics

* add conf alias to config command

* fix docs

Co-authored-by: Lucas Bertrand <lucas.bertrand.22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colin-axner colin-axner colin-axner approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

@fedekunze fedekunze Awaiting requested review from fedekunze

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ilgooz @colin-axner