Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor update message construction #431

Merged
merged 6 commits into from
Mar 22, 2021

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Feb 18, 2021

ref: #425

@colin-axner colin-axner changed the title Colin/425 refactor update msgs refactor update msgs Feb 18, 2021
@@ -166,7 +166,7 @@ func (rp *relayMsgRecvPacket) Msg(src, dst *Chain) (sdk.Msg, error) {
if rp.dstComRes == nil {
return nil, fmt.Errorf("receive packet [%s]seq{%d} has no associated proofs", src.ChainID, rp.seq)
}
version := clienttypes.ParseChainID(src.PathEnd.ChainID)
version := clienttypes.ParseChainID(src.ChainID)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The relayer always confuses me, but I don't think we verify the path end chain id often and it is unclear to me if it is the chain id of the chain the client is on or the chain id of the client itself. We should just rely on the chain id associated with the light client here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this becomes problematic if the chain-ids are swapped in the config for path end

@colin-axner colin-axner marked this pull request as ready for review February 18, 2021 14:21
@colin-axner
Copy link
Contributor Author

Started taking this on, but the bug report was a false alarm

cleans up handshakes. I was going to fix the recv and acks part but the logic is super messy to detangle. I'd prefer to put this off until I get an actual bug report

colin-axner and others added 2 commits March 9, 2021 14:49
)

* bump sdk version to v0.41.3 (#430)

* bump sdk version

* bump SDK to v0.41.3

* inital work for refactoring state based relaying

* Modify relayPacketFromSequence

* update tendermint client to not prune light blocks (#437)

* Address comments and fix lint issues

* Fix lint issues

* Remove onRtyErr (lint issue)

* typo fix (#438)

* disable tm pruning (#441)

* update release naming (#442)

* Implement swagger docs and fix path validation (#434)

* Add swagger setup

* Add some routes docs and swagger ui

* Add few more route docs

* Add swagger docs for remaining routes

* Fix golint issues

* Fix unused lint issues

* check chain-id in AddChain

* add a light client database lock (#447)

Add a lock to prevent multiple processes from attempting to access the light client database at the same time. This typically resulted in unnecessary errors or even panics

* Close database connection even if second error triggers (#449)

Co-authored-by: Mark <mjackson@microtick.com>

* address comments

Co-authored-by: akhilkumarpilli <akhilkumar7947@gmail.com>
Co-authored-by: Afanti <fanjiahe2000@163.com>
Co-authored-by: Akhil Kumar P <36399231+akhilkumarpilli@users.noreply.github.com>
Co-authored-by: Mark | Microtick <409166+mark-microtick@users.noreply.github.com>
Co-authored-by: Mark <mjackson@microtick.com>
@colin-axner colin-axner changed the title refactor update msgs refactor state based relaying Mar 10, 2021
@colin-axner colin-axner changed the title refactor state based relaying refactor update message construction Mar 10, 2021
Copy link
Collaborator

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colin-axner colin-axner merged commit 30b7ce5 into master Mar 22, 2021
@colin-axner colin-axner deleted the colin/425-refactor-update-msgs branch March 22, 2021 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants