Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misbehaviour Monitoring #457

Merged
merged 5 commits into from
Mar 22, 2021
Merged

Misbehaviour Monitoring #457

merged 5 commits into from
Mar 22, 2021

Conversation

akhilkumarpilli
Copy link
Contributor

@akhilkumarpilli akhilkumarpilli commented Mar 15, 2021 •
edited by colin-axner
Loading

closes: #112

colin-axner
colin-axner reviewed Mar 15, 2021
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

relayer/naive-strategy.go Outdated Show resolved Hide resolved
relayer/naive-strategy.go Outdated Show resolved Hide resolved
relayer/naive-strategy.go Outdated Show resolved Hide resolved
relayer/naive-strategy.go Outdated Show resolved Hide resolved
relayer/naive-strategy.go Outdated Show resolved Hide resolved
relayer/naive-strategy.go Outdated Show resolved Hide resolved
relayer/naive-strategy.go Outdated Show resolved Hide resolved
relayer/naive-strategy.go Show resolved Hide resolved
@colin-axner colin-axner changed the title Handle misbehaviour on update client event Misbehaviour Monitoring Mar 15, 2021
colin-axner
colin-axner reviewed Mar 18, 2021
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo! Looks great! Still a lot of more complexity we need to add but the building blocks are there. Lets get integration tests in and then merge this and go from there

relayer/naive-strategy.go Outdated Show resolved Hide resolved
relayer/naive-strategy.go Outdated Show resolved Hide resolved
@colin-axner colin-axner marked this pull request as ready for review March 18, 2021 10:43
colin-axner
colin-axner reviewed Mar 18, 2021
View reviewed changes
relayer/misbehaviour.go Outdated Show resolved Hide resolved
relayer/misbehaviour.go Outdated Show resolved Hide resolved
fedekunze
fedekunze reviewed Mar 19, 2021
View reviewed changes
relayer/misbehaviour.go Outdated Show resolved Hide resolved
relayer/misbehaviour.go Outdated Show resolved Hide resolved
relayer/misbehaviour.go Outdated Show resolved Hide resolved
relayer/misbehaviour.go Outdated Show resolved Hide resolved
relayer/misbehaviour.go Outdated Show resolved Hide resolved
relayer/misbehaviour.go Outdated Show resolved Hide resolved
relayer/misbehaviour.go Outdated Show resolved Hide resolved
cwgoes
cwgoes approved these changes Mar 20, 2021
View reviewed changes
Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, looks solid to me

Note that this is not incentive-compatible (also, the relayer may waste lots of gas relaying nonsense headers), but I think this is fine for now.

colin-axner
colin-axner approved these changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, I will handle integration tests in a followup

@colin-axner colin-axner merged commit 87cef08 into master Mar 22, 2021
@colin-axner colin-axner deleted the akhil/misbehaviour-handling branch March 22, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwgoes cwgoes cwgoes approved these changes

@colin-axner colin-axner colin-axner approved these changes

@fedekunze fedekunze fedekunze approved these changes

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misbehaviour monitoring & relay
4 participants
@akhilkumarpilli @cwgoes @colin-axner @fedekunze