Feature/ add substrate queries #942
Conversation
|
@jtieri any idea on how to fix it? |
TxCorpi0x
requested review from
jackzampolin,
jtieri,
boojamya and
mark-rushakoff
as code owners
TxCorpi0x
force-pushed
the
feature/substrate-queries
branch
from
afb0346
to
1862016
Compare
# Conflicts: # go.mod # go.sum # ibctest/go.mod # ibctest/go.sum # relayer/chains/substrate/construct.go # relayer/chains/substrate/errors.go # relayer/chains/substrate/event_parser.go # relayer/chains/substrate/provider.go
|
|
||
| // QueryUnbondingPeriod returns the unbonding period of the chain | ||
| func (sp *SubstrateProvider) QueryUnbondingPeriod(ctx context.Context) (time.Duration, error) { | ||
| return 0, nil |
There was a problem hiding this comment.
After some light Googling I see that Polkadot has an unbonding period of 28 days, my naive understanding is that all stake in Polkadot is locked up on the relay chain so does that mean the 28 day unbonding period applies in all cases no matter what Parachain may be actually connecting to IBC?
If so could this be hardcoded to 28 days?
There was a problem hiding this comment.
yes, the unbonding period would apply to all parachains secured by the relaychain. However, the duration of the unbonding period is dependent on the network. For instance Kusama has a 7 day unbonding period. So we'll probably need to use a switch statement for that. I'll add it in another PR.
| // QueryBalanceWithAddress returns the amount of coins in the relayer account with address as input | ||
| // TODO add pagination support | ||
| func (sp *SubstrateProvider) QueryBalanceWithAddress(ctx context.Context, address string) (sdk.Coins, error) { | ||
| // TODO: addr might need to be passed as byte not string |
There was a problem hiding this comment.
Looks like this TODO may no longer be needed
| if keyName == "" { | ||
| addr, err = sp.Address() | ||
| } else { | ||
| sp.Config.Key = keyName |
There was a problem hiding this comment.
This would change the SubstrateProvider's configured key in memory but not on disk so later operations could be referencing two different keys, the one on disk in the config file or the one now referenced in memory. As a consumer of this API it would be an unexpected side effect for a method named QueryBalance to modify state instead of just querying some data. In the cosmos implementation we just throw an error if the keyName argument is invalid for any reason whether it's an empty string or there is no key that matches the name.
There was a problem hiding this comment.
Yeah, that makes sense. I'll resolve it in another PR.
Description
Query methods are available in the
query.goin thesubstratepackage and it's methods are being used by thesubstratepackage and the rest of the packages of the relayer code-base.Added Methods to
query.goQueryBalanceQueryBalanceWithAddressQueryClientStateResponseQueryClientStateQueryClientConsensusStateQueryUpgradeProofQueryUpgradedClientQueryUpgradedConsStateQueryConsensusStateQueryConnectionQueryConnectionsQueryConnectionsUsingClientGenerateConnHandshakeProofQueryChannelQueryChannelClientQueryConnectionChannelsQueryChannelsQueryPacketCommitmentsQueryPacketAcknowledgementsQueryUnreceivedPacketsQuerySendPacketQueryRecvPacketQueryUnreceivedAcknowledgementsQueryNextSeqRecvQueryPacketCommitmentQueryPacketAcknowledgementQueryPacketReceiptQueryLatestHeightQueryHeaderAtHeightQueryDenomTraceQueryDenomTracesQueryConsensusStateABCI