remove-unnecessary-events

[sangier]

Description

WIP on #108. Currently this PR :

• removes ICS20Tansfer events according to the spec.
• removes PacketCommited and AckCommitted events from IBCStore

What is missing :

• update event management for multipayalod (currently unsupported) - e.g. writeAck event may be redundant - evaluate
• check events once Change counterpartyInfo to channel #100 is merged
• pass e2e

closes: #108

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
• Wrote unit and integration tests.
• Added relevant natspec and godoc comments.
• Provide a conventional commit message to follow the repository standards.
• Re-reviewed Files changed in the GitHub PR explorer.
• Review SonarCloud Report in the comment section below once CI passes.

[sangier]

Note this, I changed the visibility here to have access to this function to properly test the logic of the foreignDenoms test without relying on the events. However it may not be the ideal solutions.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.77%. Comparing base (71d82b4) to head (c7e0816).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   93.89%   93.77%   -0.13%     
==========================================
  Files           9        9              
  Lines         311      305       -6     
==========================================
- Hits          292      286       -6     
  Misses         19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sangier]

Noted that currently our code:

• Doesn't emit an event on an update client - in the spec we do so
• We do emit events for PacketCommited and AckCommitted - while in the spec 1,2 we don't.

My take is that we should add the updateClient event and remove the Committed events. Committed events will be emitted right before the router events and, like those, they emit the packet, thus they appear to be redundant.