Skip to content

Commit

Permalink
Address some comments on PR/5048 (apache#19)
Browse files Browse the repository at this point in the history
* Fix file permissions.

* Delete dead test.
Update postcommit project paths.
Drop 'Gradle' from Python precommit PR trigger.
  • Loading branch information
lukecwik authored and swegner committed Apr 9, 2018
1 parent ee69b4c commit c73672d
Show file tree
Hide file tree
Showing 7 changed files with 5 additions and 65 deletions.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ job('beam_PostCommit_Java_ValidatesRunner_Apex_Gradle') {
steps {
gradle {
rootBuildScriptDir(common_job_properties.checkoutDir)
tasks(':runners:apex:validatesRunner')
tasks(':beam-runners-apex:validatesRunner')
for (String gradle_switch : gradle_switches) {
switches(gradle_switch)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ job('beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle') {
steps {
gradle {
rootBuildScriptDir(common_job_properties.checkoutDir)
tasks(':runners:google-cloud-dataflow-java:validatesRunner')
tasks(':beam-runners-google-cloud-dataflow-java:validatesRunner')
for (String gradle_switch : gradle_switches) {
switches(gradle_switch)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ job('beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle') {
steps {
gradle {
rootBuildScriptDir(common_job_properties.checkoutDir)
tasks(':runners:gearpump:validatesRunner')
tasks(':beam-runners-gearpump:validatesRunner')
for (String gradle_switch : gradle_switches) {
switches(gradle_switch)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ job('beam_PostCommit_Java_ValidatesRunner_Spark_Gradle') {
steps {
gradle {
rootBuildScriptDir(common_job_properties.checkoutDir)
tasks(':runners:spark:validatesRunner')
tasks(':beam-runners-spark:validatesRunner')
for (String gradle_switch : gradle_switches) {
switches(gradle_switch)
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ job('beam_PreCommit_Python_GradleBuild') {

def gradle_command_line = './gradlew ' + gradle_switches.join(' ') + ' :pythonPreCommit'
// Sets that this is a PreCommit job.
common_job_properties.setPreCommit(delegate, gradle_command_line, 'Run Python Gradle PreCommit')
common_job_properties.setPreCommit(delegate, gradle_command_line, 'Run Python PreCommit')
steps {
gradle {
rootBuildScriptDir(common_job_properties.checkoutDir)
Expand Down
Empty file modified build_rules.gradle
100755 → 100644
Empty file.

0 comments on commit c73672d

Please sign in to comment.