Fixed bug with matching default table with alias #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added checking if tables expression contains aliases to match with config settings
Zhaars
changed the title
Lagovas
reviewed
Oct 25, 2022
encryptor/utils_test.go
Outdated
| dialect dialect.Dialect | ||
| }{ | ||
| { | ||
| query: `SELECT "id", "email", "mobile_number" AS "mobileNumber" FROM "users" AS "User" where "User"."is_active"`, |
There was a problem hiding this comment.
lets use a bit more complicated queries with several aliased tables in the FROM statement to be sure that we use first from the list
> > Added more complicated tests/extend mapColumnsToAliases func with mapColumnsToAliases
> > Added more complicated tests/extend mapColumnsToAliases func with mapColumnsToAliases
Zhaars
changed the title
Added integration test to cover matching tables with same fields
Lagovas
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Acra expects that columns in
SELECTstatement haven't been aliased if FROM has a non-aliased table or they should have proper alias. But databases allow specific alias for table but use columns without an alias.So if the query contains Columns without aliases and the table is aliased, Acra should consider this table as default. Added checking for containing aliases in tables expressions and switch between extracting tables functions depending on queries.
Checklist
with new changes