Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Codecov GitHub checks #8

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Disable Codecov GitHub checks #8

merged 1 commit into from
Aug 15, 2024

Conversation

seqre
Copy link
Member

@seqre seqre commented Aug 15, 2024

For now test coverage is only informative and the GitHub checks shown in the review are annoying. For the time being, we can include this change to disable those checks globally from the "Files changed" view. Once we actually start caring for code coverage, we can revert this.

Documentation: https://docs.codecov.com/docs/github-checks

@seqre seqre requested review from m4tx and Iipin August 15, 2024 02:31
@seqre seqre self-assigned this Aug 15, 2024
Copy link

codecov bot commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Flag Coverage Δ
rust 11.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@seqre
Copy link
Member Author

seqre commented Aug 15, 2024

Someone please reword the commit to meet our convention and force-pushes, I don't have local setup set up atm and github.dev is broken rn lol

@m4tx m4tx merged commit 8e4626f into master Aug 15, 2024
17 checks passed
@m4tx m4tx deleted the codecov-config branch August 15, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants