-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run only external deps tests #96
Conversation
Why would this fix the issue? The tables/databases are not shared between tests, so I can't see why disabling parallelization would fix this. I was suspecting some data race or something similar when connecting to Postgres (removing the database is done from a separate connection, so I thought there might be something funky going on here). |
As suspected, I just got the same error when testing locally with It would be nice to either find out the real cause of the issue, or maybe just live in ignorance and add
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more. |
I get it now, I think we should merge this PR as is and create a task to investigate that issue separately. What do you think @m4tx? |
I think there are two sensible solutions for now:
If you feel like 2 is not sensible or don't have time to do that, we can just merge this now. |
I think it's worth playing around with it and trying to figure that out, if possible with minor effort. I've created a ticket to track it: https://github.com/orgs/cot-rs/projects/2/views/7?pane=issue&itemId=94050368 If no root cause is found, we can always default to that In the meantime, I'll merge this. |
This is done to fix https://github.com/cot-rs/cot/actions/runs/12728982874/job/35480378199#step:8:441
Also, it runs only ignored tests to speed up the pipeline.