Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Bug Fix: Tab focus doesn't reach Dark mode toggle button #453

Merged
merged 5 commits into from
Nov 30, 2021

Conversation

bhavykhatri
Copy link
Contributor

@bhavykhatri bhavykhatri commented Nov 30, 2021

Description

This is a fix for accessibility bug

  • if you press tab then the focus doesn't reach dark mode toggle button
  • After focus should reach the dark mode toggle button, pressing enter button should change the theme of website
    image

e.g. Fixes #(issue)
-->

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How has this been tested

  • I have run bash ./tools/deploy.sh --dry-run (at the root of the project) locally and passed
  • I have tested this feature in the browser

Test Configuration

  • Browser type & version:
  • Operating system: Windows
  • Ruby version: 2.7.4p191
  • Bundler version: 2.2.30
  • Jekyll version: 4.2.1

Checklist

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@bhavykhatri
Copy link
Contributor Author

@cotes2020

_includes/sidebar.html Outdated Show resolved Hide resolved
_includes/mode-toggle.html Outdated Show resolved Hide resolved
_includes/sidebar.html Show resolved Hide resolved
@cotes2020 cotes2020 merged commit 707466b into cotes2020:master Nov 30, 2021
dkbnz pushed a commit to dkbnz/jekyll-theme-chirpy that referenced this pull request Jul 12, 2022
Ap3x pushed a commit to Ap3x/ap3x.github.com that referenced this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants