CXXCBC-119: Set value of subdoc exists to "true" or "false" if result is success or path-not-found #452
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Path not found errors were cleared in #444. In addition to that, the value of the spec result should be set to the JSON representation of the exists field if the result was success or path-not-found. Relevant section of the RFC:
Changes
exists
boolean forexists
spec resultspath_not_found
error inlookup_in_replica_request::make_response
, to avoid having to duplicate the logic forlookup_in_any_replica
andlookup_in_all_replicas
. Remove the checks for apath_not_found
error code everywhere that's no longer necessary because of this change.exists
subdoc resultExample
will output