CBL-4648 : Use Swift Private Module Map for ObjC headers #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Used Swift Private Module Map for the ObjC headers instead of putting the ObjC headers that are supposed to be private in the main module map file and use the post-processing script (remote_private_headers.sh) to remove the headers after build. * Removed the main handcrafted CouchbaseLiteSwift.modulemap and CouchbaseLiteSwift-EE.modulemap and let XCode generates them instead. * Removed remove_private_headers.sh and also the build phrase step that calls the script from the project. * Fixed build_xcframework.sh when running the script with relative out directory path (xcodebuild -create-xcframework requires absolute paths for the dSYM directory). * Changed file mode of all scripts in Scripts to be executable.
velicuvlad
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used Swift Private Module Map for the ObjC headers instead of using a hack by putting the ObjC headers which are supposed to be private in the main module map file and using the post-processing script (remote_private_headers.sh) to remove them after build. (Ref : https://clang.llvm.org/docs/Modules.html#private-module-map-files)
Removed the main handcrafted CouchbaseLiteSwift.modulemap and CouchbaseLiteSwift-EE.modulemap and let XCode generates them instead.
Removed remove_private_headers.sh and also the build phrase step that calls the script from the project.
Fixed build_xcframework.sh when running the script with relative out directory path (xcodebuild -create-xcframework requires absolute paths for the dSYM directory).
Changed file mode of all scripts in Scripts to be executable.
Companion PR : https://github.com/couchbaselabs/couchbase-lite-ios-ee/pull/194